From 2a3c267906c5c23418c9e2d67db086f9b15a765e Mon Sep 17 00:00:00 2001
From: lumapu <lp@lufami.de>
Date: Sat, 22 Oct 2022 23:35:56 +0200
Subject: [PATCH] added link to git commit from git sha in footer (feature
 request from @stefan123t)

---
 tools/esp8266/html/api.js                      |  9 +++++++++
 tools/esp8266/html/index.html                  | 13 ++++++++-----
 tools/esp8266/html/serial.html                 |  4 +++-
 tools/esp8266/html/setup.html                  |  4 +++-
 tools/esp8266/html/update.html                 |  4 +++-
 tools/esp8266/html/visualization.html          | 11 +++++++----
 tools/esp8266/scripts/auto_firmware_version.py |  2 +-
 7 files changed, 34 insertions(+), 13 deletions(-)

diff --git a/tools/esp8266/html/api.js b/tools/esp8266/html/api.js
index d3288c8b..d628ad17 100644
--- a/tools/esp8266/html/api.js
+++ b/tools/esp8266/html/api.js
@@ -93,3 +93,12 @@ function span(val, cl=null, id=null) {
 function br() {
     return document.createElement('br');
 }
+
+function link(dst, text, target=null) {
+    var a = document.createElement('a');
+    var t = document.createTextNode(text);
+    a.href = dst;
+    a.target = target;
+    a.appendChild(t);
+    return a;
+}
diff --git a/tools/esp8266/html/index.html b/tools/esp8266/html/index.html
index cc7f5f08..86febfdb 100644
--- a/tools/esp8266/html/index.html
+++ b/tools/esp8266/html/index.html
@@ -65,7 +65,7 @@
             <p class="right"><a href="/api">REST API</a></p>
         </div>
         <script type="text/javascript">
-            var mIntervalSet = false;
+            var exeOnce = true;
 
             function apiCb(obj) {
                 var e = document.getElementById("apiResult");
@@ -88,8 +88,11 @@
             function parseSys(obj) {
                 // Disclaimer
                 //if(obj["disclaimer"] == false) sessionStorage.setItem("gDisclaimer", promptFunction());
-
-                document.getElementById("version").innerHTML = "Git SHA: " + obj["build"] + " :: " + obj["version"];
+                if(true == exeOnce) {
+                    document.getElementById("version").appendChild(
+                        link("https://github.com/lumapu/ahoy/commits/" + obj["build"], "Git SHA: " + obj["build"] + " :: " + obj["version"], "_blank")
+                    );
+                }
                 document.getElementById("wifi_rssi").innerHTML = obj["wifi_rssi"];
 
                 var date = new Date(obj["ts_now"] * 1000);
@@ -175,9 +178,9 @@
                     parseIv(obj["inverter"]);
                     parseWarnInfo(obj["warnings"], obj["infos"]);
                     document.getElementById("refresh").innerHTML = obj["refresh_interval"];
-                    if(false == mIntervalSet) {
+                    if(true == exeOnce) {
                         window.setInterval("getAjax('/api/index', parse)", obj["refresh_interval"] * 1000);
-                        mIntervalSet = true;
+                        exeOnce = false;
                     }
                 }
                 else
diff --git a/tools/esp8266/html/serial.html b/tools/esp8266/html/serial.html
index 2744e03b..608802f6 100644
--- a/tools/esp8266/html/serial.html
+++ b/tools/esp8266/html/serial.html
@@ -74,7 +74,9 @@
                     + ("0"+sec).substr(-2);
 
                 if(false == mIntervalSet) {
-                    document.getElementById("version").innerHTML = "Git SHA: " + obj["build"] + " :: " + obj["version"];
+                    document.getElementById("version").appendChild(
+                        link("https://github.com/lumapu/ahoy/commits/" + obj["build"], "Git SHA: " + obj["build"] + " :: " + obj["version"], "_blank")
+                    );
                     window.setInterval("getAjax('/api/system', parseSys)", 10000);
                     mIntervalSet = true;
                 }
diff --git a/tools/esp8266/html/setup.html b/tools/esp8266/html/setup.html
index b73d4ebc..20553286 100644
--- a/tools/esp8266/html/setup.html
+++ b/tools/esp8266/html/setup.html
@@ -268,7 +268,9 @@
             function parseSys(obj) {
                 for(var i of [["device", "device_name"], ["ssid", "ssid"]])
                     document.getElementsByName(i[0])[0].value = obj[i[1]];
-                document.getElementById("version").innerHTML = "Git SHA: " + obj["build"] + " :: " + obj["version"];
+                document.getElementById("version").appendChild(
+                    link("https://github.com/lumapu/ahoy/commits/" + obj["build"], "Git SHA: " + obj["build"] + " :: " + obj["version"], "_blank")
+                );
             }
 
             function parseIv(obj) {
diff --git a/tools/esp8266/html/update.html b/tools/esp8266/html/update.html
index 5f4f033a..8c9d37de 100644
--- a/tools/esp8266/html/update.html
+++ b/tools/esp8266/html/update.html
@@ -26,7 +26,9 @@
         </div>
         <script type="text/javascript">
             function parseSys(obj) {
-                document.getElementById("version").innerHTML = "Git SHA: " + obj["build"] + " :: " + obj["version"];
+                document.getElementById("version").appendChild(
+                    link("https://github.com/lumapu/ahoy/commits/" + obj["build"], "Git SHA: " + obj["build"] + " :: " + obj["version"], "_blank")
+                );
             }
 
             getAjax("/api/system", parseSys);
diff --git a/tools/esp8266/html/visualization.html b/tools/esp8266/html/visualization.html
index b1c7e1fb..8779c42e 100644
--- a/tools/esp8266/html/visualization.html
+++ b/tools/esp8266/html/visualization.html
@@ -19,9 +19,12 @@
             <p class="right" id="version"></p>
         </div>
         <script type="text/javascript">
-            var intervalSet = false;
+            var exeOnce = true;
             function parseSys(obj) {
-                document.getElementById("version").innerHTML = "Git SHA: " + obj["build"] + " :: " + obj["version"];
+                if(exeOnce == true) {
+                    document.getElementById("version").appendChild(
+                        link("https://github.com/lumapu/ahoy/commits/" + obj["build"], "Git SHA: " + obj["build"] + " :: " + obj["version"], "_blank")
+                    );}
             }
 
             function parseIv(obj, root) {
@@ -111,9 +114,9 @@
                     parseSys(obj["system"]);
                     parseIv(obj["inverter"], obj);
                     document.getElementById("refresh").innerHTML = obj["refresh_interval"];
-                    if(false == intervalSet) {
+                    if(true == exeOnce) {
                         window.setInterval("getAjax('/api/live', parse)", obj["refresh_interval"] * 1000);
-                        intervalSet = true;
+                        exeOnce = false;
                     }
                 }
                 else
diff --git a/tools/esp8266/scripts/auto_firmware_version.py b/tools/esp8266/scripts/auto_firmware_version.py
index a4781fbf..784b2615 100644
--- a/tools/esp8266/scripts/auto_firmware_version.py
+++ b/tools/esp8266/scripts/auto_firmware_version.py
@@ -21,7 +21,7 @@ def get_firmware_specifier_build_flag():
     except:
         build_version = "g0000000"
 
-    build_flag = "-D AUTO_GIT_HASH=\\\"" + build_version + "\\\""
+    build_flag = "-D AUTO_GIT_HASH=\\\"" + build_version[1:] + "\\\""
     print ("Firmware Revision: " + build_version)
     return (build_flag)