From 010aa25f238dadde582c303968d1996f265dc705 Mon Sep 17 00:00:00 2001 From: KenTandrian Date: Sat, 10 Oct 2026 16:13:10 +0700 Subject: [PATCH] refactor(client): address review feedback on shell and dialogs --- apps/client/src/app/components/footer/footer.component.ts | 8 ++++---- .../src/app/components/header/header.component.html | 2 +- .../user-account-membership/user-account-membership.html | 2 +- apps/client/src/app/util/date.util.ts | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/client/src/app/components/footer/footer.component.ts b/apps/client/src/app/components/footer/footer.component.ts index 8f628be1fe..2d9ee58309 100644 --- a/apps/client/src/app/components/footer/footer.component.ts +++ b/apps/client/src/app/components/footer/footer.component.ts @@ -24,27 +24,27 @@ import { openOutline } from 'ionicons/icons'; templateUrl: './footer.component.html' }) export class GfFooterComponent { - public readonly info = input.required(); + public readonly info = input.required(); protected readonly currentYear = new Date().getFullYear(); protected readonly hasPermissionForStatistics = computed(() => { return hasPermission( - this.info().globalPermissions, + this.info()?.globalPermissions, permissions.enableStatistics ); }); protected readonly hasPermissionForSubscription = computed(() => { return hasPermission( - this.info().globalPermissions, + this.info()?.globalPermissions, permissions.enableSubscription ); }); protected readonly hasPermissionToAccessFearAndGreedIndex = computed(() => { return hasPermission( - this.info().globalPermissions, + this.info()?.globalPermissions, permissions.enableFearAndGreedIndex ); }); diff --git a/apps/client/src/app/components/header/header.component.html b/apps/client/src/app/components/header/header.component.html index 9a00924561..48ed63ab34 100644 --- a/apps/client/src/app/components/header/header.component.html +++ b/apps/client/src/app/components/header/header.component.html @@ -144,7 +144,7 @@ class="no-max-width" xPosition="before" [overlapTrigger]="true" - (closed)="assistantElement()?.setIsOpen(false)" + (closed)="assistantElement().setIsOpen(false)" > - @if (user?.subscription?.offer?.isRenewal) { + @if (user.subscription.offer.isRenewal) { Renew Plan } @else { Upgrade Plan diff --git a/apps/client/src/app/util/date.util.ts b/apps/client/src/app/util/date.util.ts index a04d60593e..02e42c529a 100644 --- a/apps/client/src/app/util/date.util.ts +++ b/apps/client/src/app/util/date.util.ts @@ -10,7 +10,7 @@ export function formatRelativeTime({ date, language }: { - date: Date | string; + date: Date | string | null | undefined; language?: string; }) { if (date) {