From 02765ce86429819c8b7960983fcc06ff4e3b5a35 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Tue, 25 Aug 2026 18:00:14 +0200 Subject: [PATCH] Improve validation of activities and asset profiles when combining custom asset profile symbol with data source other than MANUAL --- apps/api/src/app/import/import.service.ts | 12 ++++++++++++ .../services/data-provider/data-provider.service.ts | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/apps/api/src/app/import/import.service.ts b/apps/api/src/app/import/import.service.ts index 3d37aaeb9..313325f04 100644 --- a/apps/api/src/app/import/import.service.ts +++ b/apps/api/src/app/import/import.service.ts @@ -227,6 +227,18 @@ export class ImportService { throw new Error( `assetProfiles.${index}.symbol ("${symbol}") must be a UUID or start with the prefix "${ghostfolioPrefix}_" for the data source ("${DataSource.MANUAL}")` ); + } else if ( + dataSource !== DataSource.MANUAL && + isValidCustomAssetProfileSymbol(symbol) + ) { + const maskedDataSource = getMaskedGhostfolioDataSource({ + dataSource, + ghostfolioDataSources + }); + + throw new Error( + `assetProfiles.${index}.symbol ("${symbol}") is not valid for the data source ("${maskedDataSource}")` + ); } } diff --git a/apps/api/src/services/data-provider/data-provider.service.ts b/apps/api/src/services/data-provider/data-provider.service.ts index 5dd274751..00d6b74bc 100644 --- a/apps/api/src/services/data-provider/data-provider.service.ts +++ b/apps/api/src/services/data-provider/data-provider.service.ts @@ -260,7 +260,7 @@ export class DataProviderService implements OnModuleInit { isValidCustomAssetProfileSymbol(symbol) ) { throw new Error( - `${activityPath}.symbol ("${symbol}") is not valid for the specified data source ("${maskedDataSource}")` + `${activityPath}.symbol ("${symbol}") is not valid for the data source ("${maskedDataSource}")` ); }