fix: restore optional value input and revert call-site fallbacks

apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html

@@ -219,7 +219,7 @@
                 i18n
                 size="medium"
                 [isLoading]="isLoading"
-                [value]="assetProfile?.currency ?? null"
+                [value]="assetProfile?.currency"
                 >Currency</gf-value
               >
             </div>
@@ -228,7 +228,7 @@
                 size="medium"
                 [enableCopyToClipboardButton]="true"
                 [hidden]="!assetProfile?.isin"
-                [value]="assetProfile?.isin ?? null"
+                [value]="assetProfile?.isin"
                 >ISIN</gf-value
               >
             </div>
@@ -249,7 +249,7 @@
                 size="medium"
                 [isLoading]="isLoading"
                 [locale]="data.locale"
-                [value]="assetProfile?.activitiesCount ?? null"
+                [value]="assetProfile?.activitiesCount"
                 >Activities</gf-value
               >
             </div>

apps/client/src/app/components/holding-detail-dialog/holding-detail-dialog.html

@@ -342,7 +342,7 @@
                 size="medium"
                 [enableCopyToClipboardButton]="true"
                 [hidden]="!assetProfile?.isin"
-                [value]="assetProfile?.isin ?? null"
+                [value]="assetProfile?.isin"
                 >ISIN</gf-value
               >
             </div>

apps/client/src/app/components/portfolio-summary/portfolio-summary.component.html

@@ -5,7 +5,7 @@
       <gf-value
         class="justify-content-end"
         [isLoading]="isLoading"
-        [value]="timeInMarket ?? null"
+        [value]="timeInMarket"
       />
     </div>
   </div>
@@ -413,7 +413,7 @@
         [locale]="locale"
         [precision]="precision"
         [unit]="displayedCurrency"
-        [value]="summary?.totalValueInBaseCurrency ?? null"
+        [value]="summary?.totalValueInBaseCurrency"
       />
     </div>
   </div>

apps/client/src/app/pages/portfolio/allocations/allocations-page.html

@@ -16,9 +16,7 @@
             size="medium"
             [isLoading]="isLoading"
             [isPercent]="true"
-            [value]="
+            [value]="portfolioDetails?.summary?.filteredValueInPercentage"
-              portfolioDetails?.summary?.filteredValueInPercentage ?? null
-            "
           />
         </mat-card-header>
         <mat-card-content>
@@ -216,7 +214,7 @@
                 size="large"
                 [isLoading]="isLoading"
                 [isPercent]="true"
-                [value]="markets?.developedMarkets?.valueInPercentage ?? null"
+                [value]="markets?.developedMarkets?.valueInPercentage"
                 >Developed Markets</gf-value
               >
             </div>
@@ -226,7 +224,7 @@
                 size="large"
                 [isLoading]="isLoading"
                 [isPercent]="true"
-                [value]="markets?.emergingMarkets?.valueInPercentage ?? null"
+                [value]="markets?.emergingMarkets?.valueInPercentage"
                 >Emerging Markets</gf-value
               >
             </div>
@@ -236,7 +234,7 @@
                 size="large"
                 [isLoading]="isLoading"
                 [isPercent]="true"
-                [value]="markets?.otherMarkets?.valueInPercentage ?? null"
+                [value]="markets?.otherMarkets?.valueInPercentage"
                 >Other Markets</gf-value
               >
             </div>

libs/ui/src/lib/accounts-table/accounts-table.component.html

@@ -183,7 +183,7 @@
           class="d-inline-block justify-content-end"
           [isCurrency]="true"
           [locale]="locale()"
-          [value]="totalBalanceInBaseCurrency() ?? null"
+          [value]="totalBalanceInBaseCurrency()"
         />
       </td>
     </ng-container>
@@ -218,7 +218,7 @@
           class="d-inline-block justify-content-end"
           [isCurrency]="true"
           [locale]="locale()"
-          [value]="totalValueInBaseCurrency() ?? null"
+          [value]="totalValueInBaseCurrency()"
         />
       </td>
     </ng-container>
@@ -253,7 +253,7 @@
           class="d-inline-block justify-content-end"
           [isCurrency]="true"
           [locale]="locale()"
-          [value]="totalValueInBaseCurrency() ?? null"
+          [value]="totalValueInBaseCurrency()"
         />
       </td>
     </ng-container>

libs/ui/src/lib/value/value.component.ts

@@ -47,7 +47,7 @@ export class GfValueComponent implements AfterViewInit, OnChanges, OnDestroy {
   @Input() size: 'large' | 'medium' | 'small' = 'small';
   @Input() subLabel?: string = '';
   @Input() unit?: string | null = '';
-  @Input() value: number | string | null = '';
+  @Input() value?: number | string | null = '';
 
   @ViewChild('labelContent', { static: false })
   labelContent!: ElementRef<HTMLSpanElement>;