Refactoring

apps/api/src/app/access/access.controller.ts

@@ -41,10 +41,7 @@ export class AccessController {
       include: {
         granteeUser: true
       },
-      orderBy: [
+      orderBy: [{ granteeUserId: 'desc' }, { createdAt: 'asc' }],
-        { granteeUserId: 'desc' }, // NULL values first (public access), then user IDs
-        { createdAt: 'asc' } // Within each group, order by creation time
-      ],
       where: { userId: this.request.user.id }
     });
 

apps/client/src/app/components/access-table/access-table.component.html

@@ -72,7 +72,6 @@
                 <span i18n>Edit</span>
               </span>
             </button>
-            <hr class="my-0" />
           }
           @if (element.type === 'PUBLIC') {
             <button mat-menu-item (click)="onCopyUrlToClipboard(element.id)">
@@ -82,6 +81,11 @@
               </span>
             </button>
           }
+          @if (
+            user?.settings?.isExperimentalFeatures || element.type === 'PUBLIC'
+          ) {
+            <hr class="my-0" />
+          }
           <button mat-menu-item (click)="onDeleteAccess(element.id)">
             <span class="align-items-center d-flex">
               <ion-icon class="mr-2" name="remove-circle-outline" />

apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.component.ts

@@ -107,10 +107,10 @@ export class GfCreateOrUpdateAccessDialogComponent
   }
 
   public async onSubmit() {
-    if (this.mode === 'update') {
+    if (this.mode === 'create') {
-      await this.updateAccess();
-    } else {
       await this.createAccess();
+    } else {
+      await this.updateAccess();
     }
   }
 

apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.html

@@ -5,10 +5,10 @@
   (ngSubmit)="onSubmit()"
 >
   <h1 mat-dialog-title>
-    @if (mode === 'update') {
+    @if (mode === 'create') {
-      <span i18n>Edit access</span>
-    } @else {
       <span i18n>Grant access</span>
+    } @else {
+      <span i18n>Edit access</span>
     }
   </h1>
   <div class="flex-grow-1 py-3" mat-dialog-content>
@@ -73,15 +73,15 @@
       mat-flat-button
       type="submit"
       [disabled]="
-        mode === 'update'
+        mode === 'create'
-          ? !accessForm.valid
+          ? !(accessForm.dirty && accessForm.valid)
-          : !(accessForm.dirty && accessForm.valid)
+          : !accessForm.valid
       "
     >
-      @if (mode === 'update') {
+      @if (mode === 'create') {
-        <ng-container i18n>Update</ng-container>
-      } @else {
         <ng-container i18n>Save</ng-container>
+      } @else {
+        <ng-container i18n>Update</ng-container>
       }
     </button>
   </div>

apps/client/src/app/components/user-account-access/user-account-access.component.ts

@@ -209,27 +209,24 @@ export class GfUserAccountAccessComponent implements OnDestroy, OnInit {
   }
 
   private openUpdateAccessDialog(accessId: string) {
-    // Find the access details in the already loaded data
+    const access = this.accessesGive?.find(({ id }) => {
-    const accessDetails = this.accessesGive.find(({ id }) => {
       return id === accessId;
     });
 
-    if (!accessDetails) {
+    if (!access) {
-      this.notificationService.alert({
+      console.log('Could not find access.');
-        title: $localize`Oops! Could not find access details.`
+
-      });
       return;
     }
 
     const dialogRef = this.dialog.open(GfCreateOrUpdateAccessDialogComponent, {
       data: {
         access: {
-          alias: accessDetails.alias,
+          alias: access.alias,
-          id: accessDetails.id,
+          id: access.id,
-          grantee:
+          grantee: access.grantee === 'Public' ? null : access.grantee,
-            accessDetails.grantee === 'Public' ? null : accessDetails.grantee,
+          permissions: access.permissions,
-          permissions: accessDetails.permissions,
+          type: access.type
-          type: accessDetails.type
         }
       },
       height: this.deviceType === 'mobile' ? '98vh' : undefined,