Refactoring

apps/api/src/app/account/create-account.dto.ts

@@ -19,7 +19,7 @@ export class CreateAccountDto {
 
   @IsOptional()
   @IsString()
-  id: string;
+  id?: string;
 
   @IsBoolean()
   @IsOptional()

apps/api/src/app/import/import.controller.ts

@@ -41,11 +41,7 @@ export class ImportController {
   ): Promise<ImportResponse> {
     if (
       !this.configurationService.get('ENABLE_FEATURE_IMPORT') ||
-      (importData.accounts?.length > 0 &&
+      !hasPermission(this.request.user.permissions, permissions.createAccount)
-        !hasPermission(
-          this.request.user.permissions,
-          permissions.createAccount
-        ))
     ) {
       throw new HttpException(
         getReasonPhrase(StatusCodes.FORBIDDEN),

apps/api/src/app/import/import.service.ts

@@ -200,9 +200,9 @@ export class ImportService {
     );
 
     if (isDryRun) {
-      accountsDto.forEach((accountsDto) =>
+      accountsDto.forEach(({ id, name }) => {
-        accounts.push({ id: accountsDto.id, name: accountsDto.name })
+        accounts.push({ id, name });
-      );
+      });
     }
 
     const activities: Activity[] = [];
@@ -220,9 +220,9 @@ export class ImportService {
       unitPrice
     } of activitiesDto) {
       const date = parseISO(<string>(<unknown>dateString));
-      const validatedAccount = accounts.find(
+      const validatedAccount = accounts.find(({ id }) => {
-        (account) => account.id === accountId
+        return id === accountId;
-      );
+      });
 
       let order:
         | OrderWithAccount
@@ -239,7 +239,7 @@ export class ImportService {
           type,
           unitPrice,
           userId,
-          accountId: validatedAccount.id,
+          accountId: validatedAccount?.id,
           accountUserId: undefined,
           createdAt: new Date(),
           id: uuidv4(),
@@ -275,7 +275,7 @@ export class ImportService {
           type,
           unitPrice,
           userId,
-          accountId: validatedAccount.id,
+          accountId: validatedAccount?.id,
           SymbolProfile: {
             connectOrCreate: {
               create: {