From 08a694fd7374204cc00ed70836a2d451bca7aa70 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Germ=C3=A1n=20Mart=C3=ADn?= <github@gmartin.net>
Date: Sun, 19 Oct 2025 12:21:39 +0200
Subject: [PATCH] Refactor portfolio filter form: remove output events and
 simplify button actions

---
 libs/ui/src/lib/assistant/assistant.html      | 59 +++++++++----------
 .../portfolio-filter-form.component.html      |  1 -
 .../portfolio-filter-form.component.ts        | 16 -----
 3 files changed, 28 insertions(+), 48 deletions(-)

diff --git a/libs/ui/src/lib/assistant/assistant.html b/libs/ui/src/lib/assistant/assistant.html
index f073c3444..96b1b2b08 100644
--- a/libs/ui/src/lib/assistant/assistant.html
+++ b/libs/ui/src/lib/assistant/assistant.html
@@ -188,37 +188,34 @@
         [formControl]="portfolioFilterFormControl"
         [holdings]="holdings"
         [tags]="tags"
-        (applyFilters)="onApplyFilters()"
-        (resetFilters)="onResetFilters()"
-      >
-        <div class="d-flex w-100" gfPortfolioFilterActions>
-          <button
-            i18n
-            mat-button
-            type="button"
-            [disabled]="
-              !portfolioFilterForm.hasFilters() || portfolioFilterForm.disabled
-            "
-            (click)="portfolioFilterForm.onResetFilters()"
-          >
-            Reset Filters
-          </button>
-          <span class="gf-spacer"></span>
-          <button
-            color="primary"
-            i18n
-            mat-flat-button
-            type="button"
-            [disabled]="
-              !portfolioFilterForm.filterForm.dirty ||
-              portfolioFilterForm.disabled
-            "
-            (click)="portfolioFilterForm.onApplyFilters()"
-          >
-            Apply Filters
-          </button>
-        </div>
-      </gf-portfolio-filter-form>
+      />
+      <div class="d-flex w-100">
+        <button
+          i18n
+          mat-button
+          type="button"
+          [disabled]="
+            !portfolioFilterForm.hasFilters() || portfolioFilterForm.disabled
+          "
+          (click)="onResetFilters()"
+        >
+          Reset Filters
+        </button>
+        <span class="gf-spacer"></span>
+        <button
+          color="primary"
+          i18n
+          mat-flat-button
+          type="button"
+          [disabled]="
+            !portfolioFilterForm.filterForm.dirty ||
+            portfolioFilterForm.disabled
+          "
+          (click)="onApplyFilters()"
+        >
+          Apply Filters
+        </button>
+      </div>
     </div>
   }
 </div>
diff --git a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.html b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.html
index eceb9ef0a..e017d33d6 100644
--- a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.html
+++ b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.html
@@ -72,5 +72,4 @@
       </mat-select>
     </mat-form-field>
   </div>
-  <ng-content select="[gfPortfolioFilterActions]" />
 </form>
diff --git a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts
index beb7dc56f..10f72d761 100644
--- a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts
+++ b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts
@@ -8,12 +8,10 @@ import {
   ChangeDetectionStrategy,
   ChangeDetectorRef,
   Component,
-  EventEmitter,
   Input,
   OnChanges,
   OnDestroy,
   OnInit,
-  Output,
   forwardRef
 } from '@angular/core';
 import {
@@ -63,9 +61,6 @@ export class GfPortfolioFilterFormComponent
   @Input() tags: Filter[] = [];
   @Input() disabled = false;
 
-  @Output() applyFilters = new EventEmitter<void>();
-  @Output() resetFilters = new EventEmitter<void>();
-
   public filterForm: FormGroup;
 
   // eslint-disable-next-line @typescript-eslint/no-empty-function
@@ -134,17 +129,6 @@ export class GfPortfolioFilterFormComponent
     this.changeDetectorRef.markForCheck();
   }
 
-  public onApplyFilters() {
-    this.filterForm.markAsPristine();
-    this.onChange(this.filterForm.value as PortfolioFilterFormValue);
-    this.applyFilters.emit();
-  }
-
-  public onResetFilters() {
-    this.filterForm.reset({}, { emitEvent: true });
-    this.resetFilters.emit();
-  }
-
   public registerOnChange(fn: (value: PortfolioFilterFormValue) => void) {
     this.onChange = fn;
   }