From 0acba5806e3cca90c797232a95b0713b464e3896 Mon Sep 17 00:00:00 2001
From: Thomas <4159106+dtslvr@users.noreply.github.com>
Date: Sat, 11 Sep 2021 18:24:27 +0200
Subject: [PATCH] Improvements after code review

---
 .../src/app/portfolio/portfolio.service.spec.ts | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/apps/api/src/app/portfolio/portfolio.service.spec.ts b/apps/api/src/app/portfolio/portfolio.service.spec.ts
index 38af51d88..28747bde9 100644
--- a/apps/api/src/app/portfolio/portfolio.service.spec.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.spec.ts
@@ -17,13 +17,10 @@ describe('PortfolioService', () => {
     );
   });
 
-  /**
-   * Source: https://www.investopedia.com/terms/a/annualized-total-return.asp#annualized-return-formula-and-calculation
-   */
-  fit('Get annualized performance', async () => {
+  it('Get annualized performance', async () => {
     expect(
       portfolioService.getAnnualizedPerformancePercent({
-        daysInMarket: NaN,
+        daysInMarket: NaN, // differenceInDays of date-fns returns NaN for the same day
         netPerformancePercent: 0
       })
     ).toEqual(0);
@@ -35,6 +32,16 @@ describe('PortfolioService', () => {
       })
     ).toEqual(0);
 
+    expect(
+      portfolioService.getAnnualizedPerformancePercent({
+        daysInMarket: 365, // 1 year
+        netPerformancePercent: 0.05
+      })
+    ).toBeCloseTo(0.05);
+
+    /**
+     * Source: https://www.investopedia.com/terms/a/annualized-total-return.asp#annualized-return-formula-and-calculation
+     */
     expect(
       portfolioService.getAnnualizedPerformancePercent({
         daysInMarket: 575,