Add emergency fund coverage rule

apps/api/src/app/portfolio/portfolio.service.ts

@@ -1136,17 +1136,22 @@ export class PortfolioService {
         withSummary: true
       });
 
-    const { balanceInBaseCurrency: cashBalanceInBaseCurrency } =
+    // The cash balance of the summary is split into the emergency fund and
-      await this.accountService.getCashDetails({
+    // the remainder, both denominated in the base currency of the user
-        userId,
+    const cashBalanceInBaseCurrency = new Big(summary.cash)
-        currency: this.getUserCurrency()
+      .plus(summary.emergencyFund.cash)
-      });
+      .toNumber();
 
     const emergencyFundInBaseCurrency = userSettings.emergencyFund ?? 0;
 
     const emergencyFundHoldingsValueInBaseCurrency =
       this.getEmergencyFundHoldingsValueInBaseCurrency({ holdings });
 
+    const totalEmergencyFundInBaseCurrency = this.getTotalEmergencyFund({
+      emergencyFundHoldingsValueInBaseCurrency,
+      userSettings
+    }).toNumber();
+
     const hasOpenHoldings = Object.keys(holdings).length > 0;
 
     const marketsAdvancedTotalInBaseCurrency = getSum(
@@ -1192,14 +1197,11 @@ export class PortfolioService {
               this.exchangeRateDataService,
               this.i18nService,
               userSettings.language,
-              this.getTotalEmergencyFund({
+              totalEmergencyFundInBaseCurrency
-                emergencyFundHoldingsValueInBaseCurrency,
-                userSettings
-              }).toNumber()
             ),
-            // The coverage is only meaningful once a target has been set,
+            // The coverage is only meaningful once an emergency fund has been
-            // otherwise the set up rule already reports the missing setup
+            // set up, either by an amount or by the tagged holdings
-            ...(emergencyFundInBaseCurrency > 0
+            ...(totalEmergencyFundInBaseCurrency > 0
               ? [
                   new EmergencyFundCoverage(
                     this.exchangeRateDataService,

apps/api/src/models/rules/emergency-fund/emergency-fund-coverage.ts

@@ -4,67 +4,68 @@ import { I18nService } from '@ghostfolio/api/services/i18n/i18n.service';
 import { DEFAULT_CURRENCY, DEFAULT_LOCALE } from '@ghostfolio/common/config';
 import { RuleSettings, UserSettings } from '@ghostfolio/common/interfaces';
 
-export class EmergencyFundCoverage extends Rule<Settings> {
+import { Big } from 'big.js';
-  private cashBalanceInBaseCurrency: number;
-  private emergencyFundHoldingsValueInBaseCurrency: number;
-  private emergencyFundInBaseCurrency: number;
 
+export class EmergencyFundCoverage extends Rule<Settings> {
   public constructor(
     exchangeRateDataService: ExchangeRateDataService,
     private i18nService: I18nService,
     languageCode: string,
-    emergencyFundInBaseCurrency: number,
+    private emergencyFundInBaseCurrency: number,
-    emergencyFundHoldingsValueInBaseCurrency: number,
+    private emergencyFundHoldingsValueInBaseCurrency: number,
-    cashBalanceInBaseCurrency: number
+    private cashBalanceInBaseCurrency: number
   ) {
     super(exchangeRateDataService, {
       languageCode,
       key: EmergencyFundCoverage.name
     });
-
-    this.cashBalanceInBaseCurrency = cashBalanceInBaseCurrency;
-    this.emergencyFundHoldingsValueInBaseCurrency =
-      emergencyFundHoldingsValueInBaseCurrency;
-    this.emergencyFundInBaseCurrency = emergencyFundInBaseCurrency;
   }
 
   public evaluate(ruleSettings: Settings) {
+    if (!this.emergencyFundInBaseCurrency) {
+      return {
+        evaluation: this.i18nService.getTranslation({
+          id: 'rule.emergencyFundCoverage.false.unset',
+          languageCode: this.getLanguageCode()
+        }),
+        value: false
+      };
+    }
+
+    const placeholders = {
+      baseCurrency: ruleSettings.baseCurrency,
+      emergencyFund: this.emergencyFundInBaseCurrency.toLocaleString(
+        ruleSettings.locale
+      )
+    };
+
     // Only the holdings tagged as emergency fund are an explicit commitment,
     // the cash balance covers the remainder
     if (
-      this.emergencyFundHoldingsValueInBaseCurrency >
+      new Big(this.emergencyFundHoldingsValueInBaseCurrency).gt(
-      this.emergencyFundInBaseCurrency
+        this.emergencyFundInBaseCurrency
+      )
     ) {
       return {
         evaluation: this.i18nService.getTranslation({
+          placeholders,
           id: 'rule.emergencyFundCoverage.false.over',
-          languageCode: this.getLanguageCode(),
+          languageCode: this.getLanguageCode()
-          placeholders: {
-            baseCurrency: ruleSettings.baseCurrency,
-            emergencyFund: this.emergencyFundInBaseCurrency.toLocaleString(
-              ruleSettings.locale
-            )
-          }
         }),
         value: false
       };
     }
 
-    const coverageInBaseCurrency =
+    const coverageInBaseCurrency = new Big(
-      this.emergencyFundHoldingsValueInBaseCurrency +
+      this.emergencyFundHoldingsValueInBaseCurrency
-      this.cashBalanceInBaseCurrency;
+    ).plus(this.cashBalanceInBaseCurrency);
 
-    if (coverageInBaseCurrency < this.emergencyFundInBaseCurrency) {
+    if (coverageInBaseCurrency.lt(this.emergencyFundInBaseCurrency)) {
       return {
         evaluation: this.i18nService.getTranslation({
+          placeholders,
           id: 'rule.emergencyFundCoverage.false.under',
-          languageCode: this.getLanguageCode(),
+          languageCode: this.getLanguageCode()
-          placeholders: {
-            baseCurrency: ruleSettings.baseCurrency,
-            emergencyFund: this.emergencyFundInBaseCurrency.toLocaleString(
-              ruleSettings.locale
-            )
-          }
         }),
         value: false
       };
@@ -72,14 +73,9 @@ export class EmergencyFundCoverage extends Rule<Settings> {
 
     return {
       evaluation: this.i18nService.getTranslation({
+        placeholders,
         id: 'rule.emergencyFundCoverage.true',
-        languageCode: this.getLanguageCode(),
+        languageCode: this.getLanguageCode()
-        placeholders: {
-          baseCurrency: ruleSettings.baseCurrency,
-          emergencyFund: this.emergencyFundInBaseCurrency.toLocaleString(
-            ruleSettings.locale
-          )
-        }
       }),
       value: true
     };

apps/client/src/app/pages/i18n/i18n-page.html

@@ -151,6 +151,9 @@
         Your emergency fund of ${emergencyFund}
         ${baseCurrency} is not covered
       </li>
+      <li i18n="@@rule.emergencyFundCoverage.false.unset">
+        No emergency fund amount has been set to determine the coverage
+      </li>
       <li i18n="@@rule.emergencyFundCoverage.true">
         Your emergency fund of $&#123;emergencyFund&#125;
         $&#123;baseCurrency&#125; is covered