From 0ced77b7195e3162937c6ecb64a86f79f806ac1e Mon Sep 17 00:00:00 2001
From: KenTandrian <kenricktan11@gmail.com>
Date: Fri, 7 Mar 2025 20:10:39 +0700
Subject: [PATCH] resolve comments

---
 apps/api/src/app/auth/web-auth.service.ts         | 15 +++++++--------
 apps/client/src/app/services/web-authn.service.ts |  4 ++--
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/apps/api/src/app/auth/web-auth.service.ts b/apps/api/src/app/auth/web-auth.service.ts
index af8e57c8f..5678ef7fe 100644
--- a/apps/api/src/app/auth/web-auth.service.ts
+++ b/apps/api/src/app/auth/web-auth.service.ts
@@ -114,15 +114,14 @@ export class WebAuthService {
       const {
         credential: {
           counter,
-          id: credentialID,
+          id: credentialId,
           publicKey: credentialPublicKey
         }
       } = registrationInfo;
 
-      let existingDevice = devices.find(
-        (device) =>
-          isoBase64URL.fromBuffer(device.credentialId) === credentialID
-      );
+      let existingDevice = devices.find((device) => {
+        return isoBase64URL.fromBuffer(device.credentialId) === credentialId;
+      });
 
       if (!existingDevice) {
         /**
@@ -130,7 +129,7 @@ export class WebAuthService {
          */
         existingDevice = await this.deviceService.createAuthDevice({
           counter,
-          credentialId: Buffer.from(credentialID),
+          credentialId: Buffer.from(credentialId),
           credentialPublicKey: Buffer.from(credentialPublicKey),
           User: { connect: { id: user.id } }
         });
@@ -194,9 +193,9 @@ export class WebAuthService {
     try {
       const opts: VerifyAuthenticationResponseOpts = {
         credential: {
+          counter: device.counter,
           id: isoBase64URL.fromBuffer(device.credentialId),
-          publicKey: device.credentialPublicKey,
-          counter: device.counter
+          publicKey: device.credentialPublicKey
         },
         expectedChallenge: `${user.authChallenge}`,
         expectedOrigin: this.expectedOrigin,
diff --git a/apps/client/src/app/services/web-authn.service.ts b/apps/client/src/app/services/web-authn.service.ts
index 054f6b40e..76352cb7b 100644
--- a/apps/client/src/app/services/web-authn.service.ts
+++ b/apps/client/src/app/services/web-authn.service.ts
@@ -89,8 +89,8 @@ export class WebAuthnService {
         { deviceId }
       )
       .pipe(
-        switchMap((requestOptionsJSON) => {
-          return startAuthentication({ optionsJSON: requestOptionsJSON });
+        switchMap((optionsJSON) => {
+          return startAuthentication({ optionsJSON });
         }),
         switchMap((credential) => {
           return this.http.post<{ authToken: string }>(