From 0e3c627ec0b33fa2702d8d57827ca08f38dec6c9 Mon Sep 17 00:00:00 2001
From: Shaunak Das <51281688+shaun-ak@users.noreply.github.com>
Date: Mon, 16 Sep 2024 09:33:30 +0530
Subject: [PATCH] address pr comments

---
 .../components/access-table/access-table.component.html   | 8 +++-----
 .../app/components/access-table/access-table.component.ts | 8 ++++++--
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/apps/client/src/app/components/access-table/access-table.component.html b/apps/client/src/app/components/access-table/access-table.component.html
index eb39388ef..344be3297 100644
--- a/apps/client/src/app/components/access-table/access-table.component.html
+++ b/apps/client/src/app/components/access-table/access-table.component.html
@@ -35,9 +35,7 @@
         @if (element.type === 'PUBLIC') {
           <div class="align-items-center d-flex">
             <ion-icon class="mr-1" name="link-outline" />
-            <a
-              href="{{ baseUrl }}/{{ defaultLanguageCode }}/p/{{ element.id }}"
-              target="_blank"
+            <a target="_blank" [href]="getPublicUrl(element.id)"
               >{{ baseUrl }}/{{ defaultLanguageCode }}/p/{{ element.id }}</a
             >
           </div>
@@ -59,8 +57,8 @@
         </button>
         <mat-menu #transactionMenu="matMenu" xPosition="before">
           @if (element.type === 'PUBLIC') {
-            <button mat-menu-item (click)="copyToClipBoard(element.id)">
-              <ng-container i18n>Copy to clipboard</ng-container>
+            <button mat-menu-item (click)="onCopyToClipboard(element.id)">
+              <ng-container i18n>Copy link to clipboard</ng-container>
             </button>
           }
           <button mat-menu-item (click)="onDeleteAccess(element.id)">
diff --git a/apps/client/src/app/components/access-table/access-table.component.ts b/apps/client/src/app/components/access-table/access-table.component.ts
index 079884309..8c6f1fb01 100644
--- a/apps/client/src/app/components/access-table/access-table.component.ts
+++ b/apps/client/src/app/components/access-table/access-table.component.ts
@@ -51,8 +51,12 @@ export class AccessTableComponent implements OnChanges, OnInit {
     }
   }
 
-  public copyToClipBoard(aId: string): void {
-    this.clipboard.copy(`${this.baseUrl}/${this.defaultLanguageCode}/p/${aId}`);
+  public onCopyToClipboard(aId: string): void {
+    this.clipboard.copy(this.getPublicUrl(aId));
+  }
+
+  public getPublicUrl(aId: string): string {
+    return `${this.baseUrl}/${this.defaultLanguageCode}/p/${aId}`;
   }
 
   public onDeleteAccess(aId: string) {