Browse Source

Merge 22093c6591 into ecc35c9ffa

pull/5604/merge
Germán Martín 5 days ago
committed by GitHub
parent
commit
0febbe8ad8
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 1
      CHANGELOG.md
  2. 1
      apps/client/src/app/components/home-holdings/home-holdings.html
  3. 9
      libs/ui/src/lib/holdings-table/holdings-table.component.ts

1
CHANGELOG.md

@ -188,6 +188,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Removed the deprecated `ITEM` activity type
- Removed unneeded columns in holdings table for closed view
## 2.202.0 - 2025-09-26

1
apps/client/src/app/components/home-holdings/home-holdings.html

@ -50,6 +50,7 @@
[deviceType]="deviceType"
[hasPermissionToShowQuantities]="false"
[holdings]="holdings"
[isClosedHoldings]="holdingType === 'CLOSED'"
[locale]="user?.settings?.locale"
(holdingClicked)="onHoldingClicked($event)"
/>

9
libs/ui/src/lib/holdings-table/holdings-table.component.ts

@ -53,6 +53,7 @@ export class GfHoldingsTableComponent implements OnChanges, OnDestroy {
@Input() hasPermissionToShowQuantities = true;
@Input() hasPermissionToShowValues = true;
@Input() holdings: PortfolioPosition[];
@Input() isClosedHoldings = false;
@Input() locale = getLocale();
@Input() pageSize = Number.MAX_SAFE_INTEGER;
@ -72,15 +73,17 @@ export class GfHoldingsTableComponent implements OnChanges, OnDestroy {
public ngOnChanges() {
this.displayedColumns = ['icon', 'nameWithSymbol', 'dateOfFirstActivity'];
if (this.hasPermissionToShowQuantities) {
if (this.hasPermissionToShowQuantities && !this.isClosedHoldings) {
this.displayedColumns.push('quantity');
}
if (this.hasPermissionToShowValues) {
if (this.hasPermissionToShowValues && !this.isClosedHoldings) {
this.displayedColumns.push('valueInBaseCurrency');
}
this.displayedColumns.push('allocationInPercentage');
if (!this.isClosedHoldings) {
this.displayedColumns.push('allocationInPercentage');
}
if (this.hasPermissionToShowValues) {
this.displayedColumns.push('performance');

Loading…
Cancel
Save