Browse Source
Task/remove unused getCategoryName() from rule classes (#6688)
Remove unused getCategoryName()
pull/6690/head
Trevin Chow
1 week ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
17 changed files with
0 additions and
99 deletions
-
apps/api/src/models/rule.ts
-
apps/api/src/models/rules/account-cluster-risk/current-investment.ts
-
apps/api/src/models/rules/account-cluster-risk/single-account.ts
-
apps/api/src/models/rules/asset-class-cluster-risk/equity.ts
-
apps/api/src/models/rules/asset-class-cluster-risk/fixed-income.ts
-
apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts
-
apps/api/src/models/rules/currency-cluster-risk/current-investment.ts
-
apps/api/src/models/rules/economic-market-cluster-risk/developed-markets.ts
-
apps/api/src/models/rules/economic-market-cluster-risk/emerging-markets.ts
-
apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts
-
apps/api/src/models/rules/fees/fee-ratio-total-investment-volume.ts
-
apps/api/src/models/rules/liquidity/buying-power.ts
-
apps/api/src/models/rules/regional-market-cluster-risk/asia-pacific.ts
-
apps/api/src/models/rules/regional-market-cluster-risk/emerging-markets.ts
-
apps/api/src/models/rules/regional-market-cluster-risk/europe.ts
-
apps/api/src/models/rules/regional-market-cluster-risk/japan.ts
-
apps/api/src/models/rules/regional-market-cluster-risk/north-america.ts
|
|
@ -70,8 +70,6 @@ export abstract class Rule<T extends RuleSettings> implements RuleInterface<T> { |
|
|
|
|
|
|
|
|
public abstract evaluate(aRuleSettings: T): EvaluationResult; |
|
|
public abstract evaluate(aRuleSettings: T): EvaluationResult; |
|
|
|
|
|
|
|
|
public abstract getCategoryName(): string; |
|
|
|
|
|
|
|
|
|
|
|
public abstract getConfiguration(): Partial< |
|
|
public abstract getConfiguration(): Partial< |
|
|
PortfolioReportRule['configuration'] |
|
|
PortfolioReportRule['configuration'] |
|
|
>; |
|
|
>; |
|
|
|
|
|
@ -98,13 +98,6 @@ export class AccountClusterRiskCurrentInvestment extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return this.i18nService.getTranslation({ |
|
|
|
|
|
id: 'rule.accountClusterRisk.category', |
|
|
|
|
|
languageCode: this.getLanguageCode() |
|
|
|
|
|
}); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -57,13 +57,6 @@ export class AccountClusterRiskSingleAccount extends Rule<RuleSettings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return this.i18nService.getTranslation({ |
|
|
|
|
|
id: 'rule.accountClusterRisk.category', |
|
|
|
|
|
languageCode: this.getLanguageCode() |
|
|
|
|
|
}); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return undefined; |
|
|
return undefined; |
|
|
} |
|
|
} |
|
|
|
|
|
@ -85,13 +85,6 @@ export class AssetClassClusterRiskEquity extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return this.i18nService.getTranslation({ |
|
|
|
|
|
id: 'rule.assetClassClusterRisk.category', |
|
|
|
|
|
languageCode: this.getLanguageCode() |
|
|
|
|
|
}); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -85,13 +85,6 @@ export class AssetClassClusterRiskFixedIncome extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return this.i18nService.getTranslation({ |
|
|
|
|
|
id: 'rule.assetClassClusterRisk.category', |
|
|
|
|
|
languageCode: this.getLanguageCode() |
|
|
|
|
|
}); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -82,13 +82,6 @@ export class CurrencyClusterRiskBaseCurrencyCurrentInvestment extends Rule<Setti |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return this.i18nService.getTranslation({ |
|
|
|
|
|
id: 'rule.currencyClusterRisk.category', |
|
|
|
|
|
languageCode: this.getLanguageCode() |
|
|
|
|
|
}); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return undefined; |
|
|
return undefined; |
|
|
} |
|
|
} |
|
|
|
|
|
@ -75,13 +75,6 @@ export class CurrencyClusterRiskCurrentInvestment extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return this.i18nService.getTranslation({ |
|
|
|
|
|
id: 'rule.currencyClusterRisk.category', |
|
|
|
|
|
languageCode: this.getLanguageCode() |
|
|
|
|
|
}); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -76,13 +76,6 @@ export class EconomicMarketClusterRiskDevelopedMarkets extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return this.i18nService.getTranslation({ |
|
|
|
|
|
id: 'rule.economicMarketClusterRisk.category', |
|
|
|
|
|
languageCode: this.getLanguageCode() |
|
|
|
|
|
}); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -76,13 +76,6 @@ export class EconomicMarketClusterRiskEmergingMarkets extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return this.i18nService.getTranslation({ |
|
|
|
|
|
id: 'rule.economicMarketClusterRisk.category', |
|
|
|
|
|
languageCode: this.getLanguageCode() |
|
|
|
|
|
}); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -40,13 +40,6 @@ export class EmergencyFundSetup extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return this.i18nService.getTranslation({ |
|
|
|
|
|
id: 'rule.emergencyFund.category', |
|
|
|
|
|
languageCode: this.getLanguageCode() |
|
|
|
|
|
}); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return undefined; |
|
|
return undefined; |
|
|
} |
|
|
} |
|
|
|
|
|
@ -56,13 +56,6 @@ export class FeeRatioTotalInvestmentVolume extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return this.i18nService.getTranslation({ |
|
|
|
|
|
id: 'rule.fees.category', |
|
|
|
|
|
languageCode: this.getLanguageCode() |
|
|
|
|
|
}); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -63,13 +63,6 @@ export class BuyingPower extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return this.i18nService.getTranslation({ |
|
|
|
|
|
id: 'rule.liquidity.category', |
|
|
|
|
|
languageCode: this.getLanguageCode() |
|
|
|
|
|
}); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -70,10 +70,6 @@ export class RegionalMarketClusterRiskAsiaPacific extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return 'Regional Market Cluster Risk'; // TODO: Replace hardcoded text with i18n translation
|
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -72,10 +72,6 @@ export class RegionalMarketClusterRiskEmergingMarkets extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return 'Regional Market Cluster Risk'; // TODO: Replace hardcoded text with i18n translation
|
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -70,10 +70,6 @@ export class RegionalMarketClusterRiskEurope extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return 'Regional Market Cluster Risk'; // TODO: Replace hardcoded text with i18n translation
|
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -70,10 +70,6 @@ export class RegionalMarketClusterRiskJapan extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return 'Regional Market Cluster Risk'; // TODO: Replace hardcoded text with i18n translation
|
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|
|
|
@ -70,10 +70,6 @@ export class RegionalMarketClusterRiskNorthAmerica extends Rule<Settings> { |
|
|
}; |
|
|
}; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public getCategoryName() { |
|
|
|
|
|
return 'Regional Market Cluster Risk'; // TODO: Replace hardcoded text with i18n translation
|
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
public getConfiguration() { |
|
|
public getConfiguration() { |
|
|
return { |
|
|
return { |
|
|
threshold: { |
|
|
threshold: { |
|
|
|