From 10e2f8b058cc487a4fe124f238c81759adfa4fe2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=B8ren=20Aksel=20Helbo=20Bjergmark?=
 <sahb1239@gmail.com>
Date: Wed, 28 Feb 2024 20:47:08 +0100
Subject: [PATCH] Updates based on review comments

---
 .../data-enhancer/yahoo-finance/yahoo-finance.service.ts | 9 ++++-----
 .../data-provider/yahoo-finance/yahoo-finance.service.ts | 5 +----
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
index 098be7204..fc7c048a2 100644
--- a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
+++ b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
@@ -228,13 +228,12 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {
             { name: assetProfile.summaryProfile?.sector, weight: 1 }
           ];
         }
-      } else if (assetSubClass == AssetSubClass.CRYPTOCURRENCY) {
-        response.symbol = response.symbol.replace(
-          new RegExp(`-${DEFAULT_CURRENCY}$`),
-          DEFAULT_CURRENCY
-        );
       }
 
+      response.symbol = this.convertFromYahooFinanceSymbol(
+        assetProfile.price.symbol
+      );
+
       const url = assetProfile.summaryProfile?.website;
       if (url) {
         response.url = url;
diff --git a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
index 913e52a59..6dc9af902 100644
--- a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
+++ b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
@@ -38,10 +38,7 @@ export class YahooFinanceService implements DataProviderInterface {
   }: {
     symbol: string;
   }): Promise<Partial<SymbolProfile>> {
-    const response =
-      await this.yahooFinanceDataEnhancerService.getAssetProfile(symbol);
-
-    return response;
+    return await this.yahooFinanceDataEnhancerService.getAssetProfile(symbol);
   }
 
   public getDataProviderInfo(): DataProviderInfo {