Feature: Update Access interfaces to use AssetProfileIdentifier for holdings

apps/api/src/app/access/access.controller.ts

@@ -1,7 +1,7 @@
 import { HasPermission } from '@ghostfolio/api/decorators/has-permission.decorator';
 import { HasPermissionGuard } from '@ghostfolio/api/guards/has-permission.guard';
 import { ConfigurationService } from '@ghostfolio/api/services/configuration/configuration.service';
-import { Access } from '@ghostfolio/common/interfaces';
+import { Access, AccessSettings } from '@ghostfolio/common/interfaces';
 import { permissions } from '@ghostfolio/common/permissions';
 import type { RequestWithUser } from '@ghostfolio/common/types';
 
@@ -26,17 +26,6 @@ import { AccessService } from './access.service';
 import { CreateAccessDto } from './create-access.dto';
 import { UpdateAccessDto } from './update-access.dto';
 
-interface AccessFilter {
-  accountIds?: string[];
-  assetClasses?: string[];
-  holdings?: { dataSource: string; symbol: string }[];
-  tagIds?: string[];
-}
-
-interface AccessSettings {
-  filter?: AccessFilter;
-}
-
 @Controller('access')
 export class AccessController {
   public constructor(

apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.component.ts

@@ -1,6 +1,10 @@
 import { CreateAccessDto } from '@ghostfolio/api/app/access/create-access.dto';
 import { UpdateAccessDto } from '@ghostfolio/api/app/access/update-access.dto';
-import { Filter, PortfolioPosition } from '@ghostfolio/common/interfaces';
+import {
+  AssetProfileIdentifier,
+  Filter,
+  PortfolioPosition
+} from '@ghostfolio/common/interfaces';
 import { AccountWithPlatform } from '@ghostfolio/common/types';
 import {
   GfPortfolioFilterFormComponent,
@@ -155,7 +159,7 @@ export class GfCreateOrUpdateAccessDialogComponent
     | {
         accountIds?: string[];
         assetClasses?: string[];
-        holdings?: { dataSource: string; symbol: string }[];
+        holdings?: AssetProfileIdentifier[];
         tagIds?: string[];
       }
     | undefined {
@@ -175,7 +179,7 @@ export class GfCreateOrUpdateAccessDialogComponent
     const filter: {
       accountIds?: string[];
       assetClasses?: string[];
-      holdings?: { dataSource: string; symbol: string }[];
+      holdings?: AssetProfileIdentifier[];
       tagIds?: string[];
     } = {};
 
@@ -262,7 +266,7 @@ export class GfCreateOrUpdateAccessDialogComponent
       | {
           accountIds?: string[];
           assetClasses?: string[];
-          holdings?: { dataSource: string; symbol: string }[];
+          holdings?: AssetProfileIdentifier[];
           tagIds?: string[];
         }
       | undefined

libs/common/src/lib/interfaces/access.interface.ts

@@ -2,10 +2,12 @@ import { AccessType } from '@ghostfolio/common/types';
 
 import { AccessPermission } from '@prisma/client';
 
+import { AssetProfileIdentifier } from './asset-profile-identifier.interface';
+
 export interface AccessFilter {
   accountIds?: string[];
   assetClasses?: string[];
-  holdings?: { dataSource: string; symbol: string }[];
+  holdings?: AssetProfileIdentifier[];
   tagIds?: string[];
 }