From 115cd7ac39eff1eb43ecbd7bbf704657812c7775 Mon Sep 17 00:00:00 2001 From: prakhar sharma Date: Mon, 30 Sep 2024 18:42:02 +0530 Subject: [PATCH] Replaced direct routing in GfHoldingsTableComponent with an @Output() event emitter. --- .../src/lib/holdings-table/holdings-table.component.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts index 39a9baf5c..9216bc514 100644 --- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts +++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts @@ -18,7 +18,9 @@ import { OnChanges, OnDestroy, OnInit, - ViewChild + ViewChild, + EventEmitter, + Output } from '@angular/core'; import { MatButtonModule } from '@angular/material/button'; import { MatDialogModule } from '@angular/material/dialog'; @@ -63,6 +65,8 @@ export class GfHoldingsTableComponent implements OnChanges, OnDestroy, OnInit { @Input() locale = getLocale(); @Input() pageSize = Number.MAX_SAFE_INTEGER; + @Output() holdingClicked = new EventEmitter(); + @ViewChild(MatPaginator) paginator: MatPaginator; @ViewChild(MatSort) sort: MatSort; @@ -107,9 +111,7 @@ export class GfHoldingsTableComponent implements OnChanges, OnDestroy, OnInit { public onOpenHoldingDialog({ dataSource, symbol }: AssetProfileIdentifier) { if (this.hasPermissionToOpenDetails) { - this.router.navigate([], { - queryParams: { dataSource, symbol, holdingDetailDialog: true } - }); + this.holdingClicked.emit({ dataSource, symbol }); } }