Browse Source

Feature/clean up unused interfaces (#4685)

* Clean up unused interfaces
pull/4689/head
Thomas Kaul 2 months ago
committed by GitHub
parent
commit
11629ffd26
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 23
      apps/api/src/models/interfaces/portfolio.interface.ts
  2. 4
      libs/common/src/lib/interfaces/index.ts
  3. 9
      libs/common/src/lib/interfaces/portfolio-item.interface.ts
  4. 8
      libs/common/src/lib/interfaces/portfolio-overview.interface.ts

23
apps/api/src/models/interfaces/portfolio.interface.ts

@ -1,23 +0,0 @@
import { PortfolioItem, Position } from '@ghostfolio/common/interfaces';
import { Order } from '../order';
export interface PortfolioInterface {
get(aDate?: Date): PortfolioItem[];
getFees(): number;
getPositions(aDate: Date): {
[symbol: string]: Position;
};
getSymbols(aDate?: Date): string[];
getTotalBuy(): number;
getTotalSell(): number;
getOrders(): Order[];
getValue(aDate?: Date): number;
}

4
libs/common/src/lib/interfaces/index.ts

@ -29,8 +29,6 @@ import type { PortfolioChart } from './portfolio-chart.interface';
import type { PortfolioDetails } from './portfolio-details.interface';
import type { PortfolioDividends } from './portfolio-dividends.interface';
import type { PortfolioInvestments } from './portfolio-investments.interface';
import type { PortfolioItem } from './portfolio-item.interface';
import type { PortfolioOverview } from './portfolio-overview.interface';
import type { PortfolioPerformance } from './portfolio-performance.interface';
import type { PortfolioPosition } from './portfolio-position.interface';
import type { PortfolioReportRule } from './portfolio-report-rule.interface';
@ -116,8 +114,6 @@ export {
PortfolioHoldingResponse,
PortfolioHoldingsResponse,
PortfolioInvestments,
PortfolioItem,
PortfolioOverview,
PortfolioPerformance,
PortfolioPerformanceResponse,
PortfolioPosition,

9
libs/common/src/lib/interfaces/portfolio-item.interface.ts

@ -1,9 +0,0 @@
import { Position } from '@ghostfolio/common/interfaces';
export interface PortfolioItem {
date: string;
grossPerformancePercent: number;
investment: number;
positions: { [symbol: string]: Position };
value: number;
}

8
libs/common/src/lib/interfaces/portfolio-overview.interface.ts

@ -1,8 +0,0 @@
export interface PortfolioOverview {
cash: number;
committedFunds: number;
fees: number;
ordersCount: number;
totalBuy: number;
totalSell: number;
}
Loading…
Cancel
Save