Browse Source

Feature/make x ray rules order consistent (#134)

* Make order of X-ray rules consistent

* Update changelog
pull/136/head
Thomas 4 years ago
committed by GitHub
parent
commit
146b5201b5
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      CHANGELOG.md
  2. 14
      apps/api/src/app/portfolio/portfolio.controller.ts
  3. 4
      apps/api/src/models/portfolio.ts

1
CHANGELOG.md

@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fixed the sorting in various tables
- Made the order of the rules in the _X-ray_ section consistent
## 1.8.0 - 24.05.2021

14
apps/api/src/app/portfolio/portfolio.controller.ts

@ -315,18 +315,6 @@ export class PortfolioController {
impersonationUserId || this.request.user.id
);
let report = await portfolio.getReport();
if (
impersonationId &&
!hasPermission(
getPermissions(this.request.user.role),
permissions.readForeignPortfolio
)
) {
// TODO: Filter out absolute numbers
}
return report;
return await portfolio.getReport();
}
}

4
apps/api/src/models/portfolio.ts

@ -402,10 +402,10 @@ export class Portfolio implements PortfolioInterface {
accountClusterRisk: await this.rulesService.evaluate(
this,
[
new AccountClusterRiskCurrentInvestment(
new AccountClusterRiskInitialInvestment(
this.exchangeRateDataService
),
new AccountClusterRiskInitialInvestment(
new AccountClusterRiskCurrentInvestment(
this.exchangeRateDataService
),
new AccountClusterRiskSingleAccount(this.exchangeRateDataService)

Loading…
Cancel
Save