Browse Source

Removed deprecated SymbolProfile from activity interface

pull/7360/head
Thomas Kaul 4 days ago
parent
commit
146ee0347d
  1. 20
      apps/api/src/app/activities/activities.service.ts
  2. 3
      apps/api/src/app/endpoints/public/public.controller.ts
  3. 5
      apps/api/src/app/import/import.service.ts
  4. 8
      apps/api/src/interceptors/transform-data-source-in-response/transform-data-source-in-response.interceptor.ts
  5. 14
      libs/common/src/lib/config.ts
  6. 6
      libs/common/src/lib/interfaces/activities.interface.ts
  7. 6
      libs/common/src/lib/interfaces/responses/public-portfolio-response.interface.ts

20
apps/api/src/app/activities/activities.service.ts

@ -499,23 +499,6 @@ export class ActivitiesService {
id: balanceItem.id, id: balanceItem.id,
isDraft: false, isDraft: false,
quantity: 1, quantity: 1,
SymbolProfile: {
activitiesCount: 0,
assetClass: AssetClass.LIQUIDITY,
assetSubClass: AssetSubClass.CASH,
countries: [],
createdAt: new Date(balanceItem.date),
currency: account.currency,
dataSource:
this.dataProviderService.getDataSourceForExchangeRates(),
holdings: [],
id: account.currency,
isActive: true,
name: account.currency,
sectors: [],
symbol: account.currency,
updatedAt: new Date(balanceItem.date)
},
symbolProfileId: account.currency, symbolProfileId: account.currency,
type: ActivityType.BUY, type: ActivityType.BUY,
unitPrice: 1, unitPrice: 1,
@ -862,8 +845,7 @@ export class ActivitiesService {
feeInBaseCurrency, feeInBaseCurrency,
unitPriceInAssetProfileCurrency, unitPriceInAssetProfileCurrency,
value, value,
valueInBaseCurrency, valueInBaseCurrency
SymbolProfile: assetProfile
}; };
}) })
); );

3
apps/api/src/app/endpoints/public/public.controller.ts

@ -129,8 +129,7 @@ export class PublicController {
type, type,
unitPrice, unitPrice,
value, value,
valueInBaseCurrency, valueInBaseCurrency
SymbolProfile: assetProfile
}; };
} }
); );

5
apps/api/src/app/import/import.service.ts

@ -153,7 +153,6 @@ export class ImportService {
feeInBaseCurrency: 0, feeInBaseCurrency: 0,
id: assetProfile.id, id: assetProfile.id,
isDraft: false, isDraft: false,
SymbolProfile: assetProfile,
symbolProfileId: assetProfile.id, symbolProfileId: assetProfile.id,
type: 'DIVIDEND', type: 'DIVIDEND',
unitPrice: marketPrice, unitPrice: marketPrice,
@ -623,9 +622,7 @@ export class ImportService {
assetProfile, assetProfile,
error, error,
value, value,
valueInBaseCurrency, valueInBaseCurrency
// @ts-ignore
SymbolProfile: assetProfile
}); });
} }

8
apps/api/src/interceptors/transform-data-source-in-response/transform-data-source-in-response.interceptor.ts

@ -80,10 +80,6 @@ export class TransformDataSourceInResponseInterceptor<
paths: [ paths: [
'activities[*].assetProfile.dataSource', 'activities[*].assetProfile.dataSource',
'activities[*].dataSource', 'activities[*].dataSource',
/* @deprecated */
'activities[*].SymbolProfile.dataSource',
'assetProfile.dataSource', 'assetProfile.dataSource',
'benchmarks[*].dataSource', 'benchmarks[*].dataSource',
'errors[*].dataSource', 'errors[*].dataSource',
@ -92,10 +88,6 @@ export class TransformDataSourceInResponseInterceptor<
'holdings[*].assetProfile.dataSource', 'holdings[*].assetProfile.dataSource',
'holdings[*].dataSource', 'holdings[*].dataSource',
'items[*].dataSource', 'items[*].dataSource',
/* @deprecated */
'SymbolProfile.dataSource',
'watchlist[*].dataSource' 'watchlist[*].dataSource'
] ]
}); });

14
libs/common/src/lib/config.ts

@ -113,13 +113,6 @@ export const DEFAULT_REDACTED_PATHS = [
'activities[*].feeInAssetProfileCurrency', 'activities[*].feeInAssetProfileCurrency',
'activities[*].feeInBaseCurrency', 'activities[*].feeInBaseCurrency',
'activities[*].quantity', 'activities[*].quantity',
/* @deprecated */
'activities[*].SymbolProfile.symbolMapping',
/* @deprecated */
'activities[*].SymbolProfile.watchedByCount',
'activities[*].value', 'activities[*].value',
'activities[*].valueInBaseCurrency', 'activities[*].valueInBaseCurrency',
'balance', 'balance',
@ -150,13 +143,6 @@ export const DEFAULT_REDACTED_PATHS = [
'platforms[*].balance', 'platforms[*].balance',
'platforms[*].valueInBaseCurrency', 'platforms[*].valueInBaseCurrency',
'quantity', 'quantity',
/* @deprecated */
'SymbolProfile.symbolMapping',
/* @deprecated */
'SymbolProfile.watchedByCount',
'totalBalanceInBaseCurrency', 'totalBalanceInBaseCurrency',
'totalDividendInBaseCurrency', 'totalDividendInBaseCurrency',
'totalInterestInBaseCurrency', 'totalInterestInBaseCurrency',

6
libs/common/src/lib/interfaces/activities.interface.ts

@ -9,12 +9,6 @@ export interface Activity extends Order {
error?: ActivityError; error?: ActivityError;
feeInAssetProfileCurrency: number; feeInAssetProfileCurrency: number;
feeInBaseCurrency: number; feeInBaseCurrency: number;
/**
* @deprecated Use `assetProfile` instead
*/
SymbolProfile?: EnhancedSymbolProfile;
tagIds?: string[]; tagIds?: string[];
tags?: Tag[]; tags?: Tag[];
unitPriceInAssetProfileCurrency: number; unitPriceInAssetProfileCurrency: number;

6
libs/common/src/lib/interfaces/responses/public-portfolio-response.interface.ts

@ -27,12 +27,6 @@ export interface PublicPortfolioResponse extends PublicPortfolioResponseV1 {
'currency' | 'date' | 'fee' | 'quantity' | 'type' | 'unitPrice' 'currency' | 'date' | 'fee' | 'quantity' | 'type' | 'unitPrice'
> & { > & {
assetProfile?: EnhancedSymbolProfile; assetProfile?: EnhancedSymbolProfile;
/**
* @deprecated Use `assetProfile` instead
*/
SymbolProfile?: EnhancedSymbolProfile;
value: number; value: number;
valueInBaseCurrency: number; valueInBaseCurrency: number;
})[]; })[];

Loading…
Cancel
Save