Refactoring

apps/client/src/app/components/rule/rule-settings-dialog/rule-settings-dialog.component.ts

@@ -34,7 +34,5 @@ export class GfRuleSettingsDialogComponent {
   public constructor(
     @Inject(MAT_DIALOG_DATA) public data: IRuleSettingsDialogParams,
     public dialogRef: MatDialogRef<GfRuleSettingsDialogComponent>
-  ) {
-    this.settings = this.data.settings;
-  }
+  ) {}
 }

apps/client/src/app/components/rule/rule-settings-dialog/rule-settings-dialog.html

@@ -4,34 +4,38 @@
   <mat-form-field
     appearance="outline"
     class="w-100"
-    [ngClass]="{ 'd-none': settings.thresholdMin === undefined }"
+    [ngClass]="{ 'd-none': !data.rule.configuration.thresholdMin }"
   >
     <mat-label i18n>Threshold Min</mat-label>
     <input
       matInput
       name="thresholdMin"
       type="number"
-      [(ngModel)]="settings.thresholdMin"
+      [(ngModel)]="data.settings.thresholdMin"
     />
   </mat-form-field>
   <mat-form-field
     appearance="outline"
     class="w-100"
-    [ngClass]="{ 'd-none': settings.thresholdMax === undefined }"
+    [ngClass]="{ 'd-none': !data.rule.configuration.thresholdMax }"
   >
     <mat-label i18n>Threshold Max</mat-label>
     <input
       matInput
       name="thresholdMax"
       type="number"
-      [(ngModel)]="settings.thresholdMax"
+      [(ngModel)]="data.settings.thresholdMax"
     />
   </mat-form-field>
 </div>
 
 <div align="end" mat-dialog-actions>
   <button i18n mat-button (click)="dialogRef.close()">Close</button>
-  <button color="primary" mat-flat-button (click)="dialogRef.close(settings)">
+  <button
+    color="primary"
+    mat-flat-button
+    (click)="dialogRef.close(data.settings)"
+  >
     <ng-container i18n>Save</ng-container>
   </button>
 </div>