From 18b5d905a5445cf8643e5c7919c7ef378990f139 Mon Sep 17 00:00:00 2001
From: KenTandrian <kenricktan11@gmail.com>
Date: Tue, 27 Jan 2026 00:22:42 +0700
Subject: [PATCH] refactor(api): Use `map` for populating Yahoo Finance
 holdings

---
 .../yahoo-finance/yahoo-finance.service.ts             | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
index 869500a18..35ece7aa4 100644
--- a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
+++ b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
@@ -218,14 +218,12 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {
           }
         }
 
-        response.holdings = [];
-
-        for (const holding of assetProfile.topHoldings.holdings) {
-          response.holdings.push({
+        response.holdings = assetProfile.topHoldings.holdings.map((holding) => {
+          return {
             name: holding.holdingName,
             weight: holding.holdingPercent
-          });
-        }
+          };
+        });
       } else if (
         assetSubClass === 'STOCK' &&
         assetProfile.summaryProfile?.country