From 19333ab084fa537e6a0c2f4fdfc09dae4a773e7b Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 27 May 2023 10:48:10 +0200 Subject: [PATCH] Fix warnings (#2011) --- .../src/app/benchmark/benchmark.controller.ts | 2 +- .../data-provider/data-provider.service.ts | 3 +- ...benchmark-market-data-details.interface.ts | 2 +- libs/common/src/lib/interfaces/index.ts | 86 +++++++++---------- .../responses/benchmark-response.interface.ts | 2 +- libs/common/src/lib/types/index.ts | 16 ++-- 6 files changed, 55 insertions(+), 56 deletions(-) diff --git a/apps/api/src/app/benchmark/benchmark.controller.ts b/apps/api/src/app/benchmark/benchmark.controller.ts index 91426090e..d59a231ff 100644 --- a/apps/api/src/app/benchmark/benchmark.controller.ts +++ b/apps/api/src/app/benchmark/benchmark.controller.ts @@ -1,6 +1,6 @@ import { TransformDataSourceInRequestInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-request.interceptor'; import { TransformDataSourceInResponseInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-response.interceptor'; -import { +import type { BenchmarkMarketDataDetails, BenchmarkResponse, UniqueAsset diff --git a/apps/api/src/services/data-provider/data-provider.service.ts b/apps/api/src/services/data-provider/data-provider.service.ts index 387c71be2..c05fc3e4f 100644 --- a/apps/api/src/services/data-provider/data-provider.service.ts +++ b/apps/api/src/services/data-provider/data-provider.service.ts @@ -11,8 +11,7 @@ import { PrismaService } from '@ghostfolio/api/services/prisma/prisma.service'; import { PropertyService } from '@ghostfolio/api/services/property/property.service'; import { PROPERTY_DATA_SOURCE_MAPPING } from '@ghostfolio/common/config'; import { DATE_FORMAT, getStartOfUtcDate } from '@ghostfolio/common/helper'; -import { UserWithSettings } from '@ghostfolio/common/types'; -import { Granularity } from '@ghostfolio/common/types'; +import type { Granularity, UserWithSettings } from '@ghostfolio/common/types'; import { Inject, Injectable, Logger } from '@nestjs/common'; import { DataSource, MarketData, SymbolProfile } from '@prisma/client'; import { format, isValid } from 'date-fns'; diff --git a/libs/common/src/lib/interfaces/benchmark-market-data-details.interface.ts b/libs/common/src/lib/interfaces/benchmark-market-data-details.interface.ts index 10fdeff32..ed693b9af 100644 --- a/libs/common/src/lib/interfaces/benchmark-market-data-details.interface.ts +++ b/libs/common/src/lib/interfaces/benchmark-market-data-details.interface.ts @@ -1,4 +1,4 @@ -import { LineChartItem } from './line-chart-item.interface'; +import { LineChartItem } from '@ghostfolio/common/interfaces'; export interface BenchmarkMarketDataDetails { marketData: LineChartItem[]; diff --git a/libs/common/src/lib/interfaces/index.ts b/libs/common/src/lib/interfaces/index.ts index 538615861..93268153b 100644 --- a/libs/common/src/lib/interfaces/index.ts +++ b/libs/common/src/lib/interfaces/index.ts @@ -1,49 +1,49 @@ -import { Access } from './access.interface'; -import { Accounts } from './accounts.interface'; -import { AdminData } from './admin-data.interface'; -import { AdminJobs } from './admin-jobs.interface'; -import { AdminMarketDataDetails } from './admin-market-data-details.interface'; -import { +import type { Access } from './access.interface'; +import type { Accounts } from './accounts.interface'; +import type { AdminData } from './admin-data.interface'; +import type { AdminJobs } from './admin-jobs.interface'; +import type { AdminMarketDataDetails } from './admin-market-data-details.interface'; +import type { AdminMarketData, AdminMarketDataItem } from './admin-market-data.interface'; -import { BenchmarkMarketDataDetails } from './benchmark-market-data-details.interface'; -import { BenchmarkProperty } from './benchmark-property.interface'; -import { Benchmark } from './benchmark.interface'; -import { Coupon } from './coupon.interface'; -import { DataProviderInfo } from './data-provider-info.interface'; -import { EnhancedSymbolProfile } from './enhanced-symbol-profile.interface'; -import { Export } from './export.interface'; -import { FilterGroup } from './filter-group.interface'; -import { Filter } from './filter.interface'; -import { HistoricalDataItem } from './historical-data-item.interface'; -import { InfoItem } from './info-item.interface'; -import { LineChartItem } from './line-chart-item.interface'; -import { PortfolioChart } from './portfolio-chart.interface'; -import { PortfolioDetails } from './portfolio-details.interface'; -import { PortfolioDividends } from './portfolio-dividends.interface'; -import { PortfolioInvestments } from './portfolio-investments.interface'; -import { PortfolioItem } from './portfolio-item.interface'; -import { PortfolioOverview } from './portfolio-overview.interface'; -import { PortfolioPerformance } from './portfolio-performance.interface'; -import { PortfolioPosition } from './portfolio-position.interface'; -import { PortfolioPublicDetails } from './portfolio-public-details.interface'; -import { PortfolioReportRule } from './portfolio-report-rule.interface'; -import { PortfolioReport } from './portfolio-report.interface'; -import { PortfolioSummary } from './portfolio-summary.interface'; -import { Position } from './position.interface'; -import { BenchmarkResponse } from './responses/benchmark-response.interface'; -import { ResponseError } from './responses/errors.interface'; -import { ImportResponse } from './responses/import-response.interface'; -import { OAuthResponse } from './responses/oauth-response.interface'; -import { PortfolioPerformanceResponse } from './responses/portfolio-performance-response.interface'; -import { ScraperConfiguration } from './scraper-configuration.interface'; -import { Statistics } from './statistics.interface'; -import { Subscription } from './subscription.interface'; -import { TimelinePosition } from './timeline-position.interface'; -import { UniqueAsset } from './unique-asset.interface'; -import { UserSettings } from './user-settings.interface'; -import { User } from './user.interface'; +import type { BenchmarkMarketDataDetails } from './benchmark-market-data-details.interface'; +import type { BenchmarkProperty } from './benchmark-property.interface'; +import type { Benchmark } from './benchmark.interface'; +import type { Coupon } from './coupon.interface'; +import type { DataProviderInfo } from './data-provider-info.interface'; +import type { EnhancedSymbolProfile } from './enhanced-symbol-profile.interface'; +import type { Export } from './export.interface'; +import type { FilterGroup } from './filter-group.interface'; +import type { Filter } from './filter.interface'; +import type { HistoricalDataItem } from './historical-data-item.interface'; +import type { InfoItem } from './info-item.interface'; +import type { LineChartItem } from './line-chart-item.interface'; +import type { PortfolioChart } from './portfolio-chart.interface'; +import type { PortfolioDetails } from './portfolio-details.interface'; +import type { PortfolioDividends } from './portfolio-dividends.interface'; +import type { PortfolioInvestments } from './portfolio-investments.interface'; +import type { PortfolioItem } from './portfolio-item.interface'; +import type { PortfolioOverview } from './portfolio-overview.interface'; +import type { PortfolioPerformance } from './portfolio-performance.interface'; +import type { PortfolioPosition } from './portfolio-position.interface'; +import type { PortfolioPublicDetails } from './portfolio-public-details.interface'; +import type { PortfolioReportRule } from './portfolio-report-rule.interface'; +import type { PortfolioReport } from './portfolio-report.interface'; +import type { PortfolioSummary } from './portfolio-summary.interface'; +import type { Position } from './position.interface'; +import type { BenchmarkResponse } from './responses/benchmark-response.interface'; +import type { ResponseError } from './responses/errors.interface'; +import type { ImportResponse } from './responses/import-response.interface'; +import type { OAuthResponse } from './responses/oauth-response.interface'; +import type { PortfolioPerformanceResponse } from './responses/portfolio-performance-response.interface'; +import type { ScraperConfiguration } from './scraper-configuration.interface'; +import type { Statistics } from './statistics.interface'; +import type { Subscription } from './subscription.interface'; +import type { TimelinePosition } from './timeline-position.interface'; +import type { UniqueAsset } from './unique-asset.interface'; +import type { UserSettings } from './user-settings.interface'; +import type { User } from './user.interface'; export { Access, diff --git a/libs/common/src/lib/interfaces/responses/benchmark-response.interface.ts b/libs/common/src/lib/interfaces/responses/benchmark-response.interface.ts index 262d55fba..d47cf1864 100644 --- a/libs/common/src/lib/interfaces/responses/benchmark-response.interface.ts +++ b/libs/common/src/lib/interfaces/responses/benchmark-response.interface.ts @@ -1,4 +1,4 @@ -import { Benchmark } from '../benchmark.interface'; +import { Benchmark } from '@ghostfolio/common/interfaces'; export interface BenchmarkResponse { benchmarks: Benchmark[]; diff --git a/libs/common/src/lib/types/index.ts b/libs/common/src/lib/types/index.ts index 258ce211d..dc6f154dc 100644 --- a/libs/common/src/lib/types/index.ts +++ b/libs/common/src/lib/types/index.ts @@ -1,17 +1,17 @@ import type { AccessWithGranteeUser } from './access-with-grantee-user.type'; -import { AccountWithPlatform } from './account-with-platform.type'; -import { AccountWithValue } from './account-with-value.type'; +import type { AccountWithPlatform } from './account-with-platform.type'; +import type { AccountWithValue } from './account-with-value.type'; import type { ColorScheme } from './color-scheme.type'; import type { DateRange } from './date-range.type'; import type { Granularity } from './granularity.type'; -import { GroupBy } from './group-by.type'; -import { MarketState } from './market-state.type'; -import { Market } from './market.type'; +import type { GroupBy } from './group-by.type'; +import type { MarketState } from './market-state.type'; +import type { Market } from './market.type'; import type { OrderWithAccount } from './order-with-account.type'; import type { RequestWithUser } from './request-with-user.type'; -import { SubscriptionOffer } from './subscription-offer.type'; -import { ToggleOption } from './toggle-option.type'; -import { UserWithSettings } from './user-with-settings.type'; +import type { SubscriptionOffer } from './subscription-offer.type'; +import type { ToggleOption } from './toggle-option.type'; +import type { UserWithSettings } from './user-with-settings.type'; import type { ViewMode } from './view-mode.type'; export type {