From 19c4d2733a8eb6e4be4b7160d4d9fe409d80fd97 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sun, 10 Nov 2024 10:21:14 +0100
Subject: [PATCH] Refactoring

---
 apps/client/src/app/services/data.service.ts     | 2 +-
 libs/ui/src/lib/assistant/assistant.component.ts | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/apps/client/src/app/services/data.service.ts b/apps/client/src/app/services/data.service.ts
index cde7555b2..dccbb064a 100644
--- a/apps/client/src/app/services/data.service.ts
+++ b/apps/client/src/app/services/data.service.ts
@@ -532,7 +532,7 @@ export class DataService {
   }: {
     filters?: Filter[];
     range?: DateRange;
-  }) {
+  } = {}) {
     let params = this.buildFiltersAsQueryParams({ filters });
 
     if (range) {
diff --git a/libs/ui/src/lib/assistant/assistant.component.ts b/libs/ui/src/lib/assistant/assistant.component.ts
index 2bbf5a7c2..3a5e6a2f8 100644
--- a/libs/ui/src/lib/assistant/assistant.component.ts
+++ b/libs/ui/src/lib/assistant/assistant.component.ts
@@ -501,14 +501,12 @@ export class GfAssistantComponent implements OnChanges, OnDestroy, OnInit {
 
   private initializeFilterForm() {
     this.dataService
-      .fetchPortfolioHoldings({
-        range: 'max'
-      })
+      .fetchPortfolioHoldings()
       .pipe(takeUntil(this.unsubscribeSubject))
       .subscribe(({ holdings }) => {
         this.holdings = holdings
           .filter(({ assetSubClass }) => {
-            return assetSubClass !== 'CASH';
+            return !['CASH'].includes(assetSubClass);
           })
           .sort((a, b) => {
             return a.name?.localeCompare(b.name);