Improve exchange rate robustness

apps/api/src/app/activities/activities.service.ts

@@ -746,10 +746,10 @@ export class ActivitiesService {
         const value = new Big(order.quantity).mul(order.unitPrice).toNumber();
 
         const [
-          feeInAssetProfileCurrency,
+          feeInAssetProfileCurrency = 0,
-          feeInBaseCurrency,
+          feeInBaseCurrency = 0,
-          unitPriceInAssetProfileCurrency,
+          unitPriceInAssetProfileCurrency = 0,
-          valueInBaseCurrency
+          valueInBaseCurrency = 0
         ] = await Promise.all([
           this.exchangeRateDataService.toCurrencyAtDate(
             order.fee,

apps/api/src/app/import/import.service.ts

@@ -592,18 +592,19 @@ export class ImportService {
 
       const value = new Big(quantity).mul(unitPrice).toNumber();
 
-      const valueInBaseCurrency = this.exchangeRateDataService.toCurrencyAtDate(
+      const valueInBaseCurrency =
-        value,
+        (await this.exchangeRateDataService.toCurrencyAtDate(
-        currency ?? assetProfile.currency,
+          value,
-        userCurrency,
+          currency ?? assetProfile.currency,
-        date
+          userCurrency,
-      );
+          date
+        )) ?? 0;
 
       activities.push({
         ...order,
         error,
         value,
-        valueInBaseCurrency: await valueInBaseCurrency,
+        valueInBaseCurrency,
         // @ts-ignore
         SymbolProfile: assetProfile
       });

apps/api/src/app/portfolio/portfolio.service.ts

@@ -205,21 +205,21 @@ export class PortfolioService {
           switch (type) {
             case ActivityType.DIVIDEND:
               dividendInBaseCurrency +=
-                await this.exchangeRateDataService.toCurrencyAtDate(
+                (await this.exchangeRateDataService.toCurrencyAtDate(
                   new Big(quantity).mul(unitPrice).toNumber(),
                   currency ?? SymbolProfile.currency,
                   userCurrency,
                   date
-                );
+                )) ?? 0;
               break;
             case ActivityType.INTEREST:
               interestInBaseCurrency +=
-                await this.exchangeRateDataService.toCurrencyAtDate(
+                (await this.exchangeRateDataService.toCurrencyAtDate(
                   unitPrice,
                   currency ?? SymbolProfile.currency,
                   userCurrency,
                   date
-                );
+                )) ?? 0;
               break;
           }