From 1d948c32862bd0c6e462bb039197fdbde8b78b9c Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 8 Aug 2026 09:37:14 +0200 Subject: [PATCH] Task/improve style of placeholder in entity logo component (#7572) * Improve style * Update changelog --- CHANGELOG.md | 1 + .../src/lib/entity-logo/entity-logo.component.html | 2 +- .../src/lib/entity-logo/entity-logo.component.scss | 10 ---------- .../entity-logo/entity-logo.component.stories.ts | 13 ++++++------- 4 files changed, 8 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 663fdd1fe..cf25a0b98 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Improved the check for duplicates in the preview step of the import dividends dialog (regardless of the account) - Extended the activities import to reuse an existing account of the user by name and currency - Extended the activities import to resolve an ISIN to the symbol of the data provider +- Improved the style of the placeholder in the entity logo component - Migrated the create, detail and edit account dialogs to dedicated routes - Improved the language localization for German (`de`) diff --git a/libs/ui/src/lib/entity-logo/entity-logo.component.html b/libs/ui/src/lib/entity-logo/entity-logo.component.html index 0a7ecbcd2..fe58f8226 100644 --- a/libs/ui/src/lib/entity-logo/entity-logo.component.html +++ b/libs/ui/src/lib/entity-logo/entity-logo.component.html @@ -7,5 +7,5 @@ (error)="onError()" /> } @else if (hasPlaceholder) { -
+ } diff --git a/libs/ui/src/lib/entity-logo/entity-logo.component.scss b/libs/ui/src/lib/entity-logo/entity-logo.component.scss index 051199346..9f2ccf73d 100644 --- a/libs/ui/src/lib/entity-logo/entity-logo.component.scss +++ b/libs/ui/src/lib/entity-logo/entity-logo.component.scss @@ -11,15 +11,5 @@ height: 1.4rem; width: 1.4rem; } - - &.placeholder { - border: 1px solid rgba(var(--dark-dividers)); - } - } -} - -:host-context(.theme-dark) { - .placeholder { - border-color: rgba(var(--light-dividers)); } } diff --git a/libs/ui/src/lib/entity-logo/entity-logo.component.stories.ts b/libs/ui/src/lib/entity-logo/entity-logo.component.stories.ts index 786d54cbf..9c977eca5 100644 --- a/libs/ui/src/lib/entity-logo/entity-logo.component.stories.ts +++ b/libs/ui/src/lib/entity-logo/entity-logo.component.stories.ts @@ -45,18 +45,17 @@ export const LogoByUrl: Story = { } }; -export const Placeholder: Story = { +export const LogoOnError: Story = { args: { - hasPlaceholder: true, - size: 'large' + size: 'large', + tooltip: 'Unknown', + url: 'https://unknown.ghostfol.io' } }; -export const PlaceholderOnError: Story = { +export const Placeholder: Story = { args: { hasPlaceholder: true, - size: 'large', - tooltip: 'Unknown', - url: 'https://unknown.ghostfol.io' + size: 'large' } };