From 1dfc5cec9b92a95d5b86fc6682faaf533fcd9d03 Mon Sep 17 00:00:00 2001 From: Don Date: Thu, 12 Oct 2023 22:25:47 -0700 Subject: [PATCH] Add invalid-multi-line csv --- .../import-activities-dialog.component.ts | 1 + test/import/invalid-multi-line.csv | 4 ++++ 2 files changed, 5 insertions(+) create mode 100644 test/import/invalid-multi-line.csv diff --git a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts index 919434176..f823c68b9 100644 --- a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts +++ b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts @@ -268,6 +268,7 @@ export class ImportActivitiesDialog implements OnDestroy { return; } else if (file.name.endsWith('.csv')) { const content: string[] = fileContent.split('\n').slice(1); + try { const data = await this.importActivitiesService.importCsv({ fileContent, diff --git a/test/import/invalid-multi-line.csv b/test/import/invalid-multi-line.csv new file mode 100644 index 000000000..6fae0bd03 --- /dev/null +++ b/test/import/invalid-multi-line.csv @@ -0,0 +1,4 @@ +Date,Code,Currency,Price,Quantity,Action,Fee +12/10/2023,MSFT,USD,329.050,10,buy,0 +12/10/2023,AAPL,USD,179.050,20,,0 +12/10/2023,GOOGL,USD,138.310,30,buy,0 \ No newline at end of file