Browse Source
			
			
			Feature/always show label in value component (#1812)
			
				* Always show label while loading
* Update changelog
			
			
				pull/1813/head^2
			
			
		 
		
			
				
					
						 Thomas Kaul
					
					3 years ago
						Thomas Kaul
					
					3 years ago
					
						
							committed by
							
								 GitHub
								GitHub
							
						 
					
				 
				
			 
		 
		
			
				
					
					No known key found for this signature in database
					
						
							GPG Key ID: 4AEE18F83AFDEB23
						
					
				
			
		
		
		
	
		
			
				 2 changed files with 
17 additions and 
12 deletions
			 
			
		 
		
			
				- 
					
					
					 
					CHANGELOG.md
				
- 
					
					
					 
					libs/ui/src/lib/value/value.component.html
				
				
				
					
						
							
								
									
	
		
			
				
					|  |  | @ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ## Unreleased | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ### Changed | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | - Improved the value component by always showing the label (also while loading) | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ### Fixed | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | - Fixed an issue with the algebraic sign in the value component | 
			
		
	
	
		
			
				
					|  |  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
			
				
					|  |  | @ -48,17 +48,6 @@ | 
			
		
	
		
			
				
					|  |  |  |         </div> | 
			
		
	
		
			
				
					|  |  |  |       </ng-container> | 
			
		
	
		
			
				
					|  |  |  |     </div> | 
			
		
	
		
			
				
					|  |  |  |     <ng-container> | 
			
		
	
		
			
				
					|  |  |  |       <div *ngIf="size === 'large'"> | 
			
		
	
		
			
				
					|  |  |  |         <span class="h6" | 
			
		
	
		
			
				
					|  |  |  |           ><ng-container *ngTemplateOutlet="label"></ng-container | 
			
		
	
		
			
				
					|  |  |  |         ></span> | 
			
		
	
		
			
				
					|  |  |  |         <span *ngIf="subLabel" class="text-muted"> {{ subLabel }}</span> | 
			
		
	
		
			
				
					|  |  |  |       </div> | 
			
		
	
		
			
				
					|  |  |  |       <small *ngIf="size !== 'large'"> | 
			
		
	
		
			
				
					|  |  |  |         <ng-container *ngTemplateOutlet="label"></ng-container> | 
			
		
	
		
			
				
					|  |  |  |       </small> | 
			
		
	
		
			
				
					|  |  |  |     </ng-container> | 
			
		
	
		
			
				
					|  |  |  |   </ng-container> | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  |   <ngx-skeleton-loader | 
			
		
	
	
		
			
				
					|  |  | @ -66,8 +55,20 @@ | 
			
		
	
		
			
				
					|  |  |  |     animation="pulse" | 
			
		
	
		
			
				
					|  |  |  |     [theme]="{ | 
			
		
	
		
			
				
					|  |  |  |       height: | 
			
		
	
		
			
				
					|  |  |  |         size === 'large' ? '2.5rem' : size === 'medium' ? '2rem' : '1.5rem', | 
			
		
	
		
			
				
					|  |  |  |         size === 'large' ? '2rem' : size === 'medium' ? '1.8rem' : '1.5rem', | 
			
		
	
		
			
				
					|  |  |  |       width: '5rem' | 
			
		
	
		
			
				
					|  |  |  |     }" | 
			
		
	
		
			
				
					|  |  |  |   ></ngx-skeleton-loader> | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  |   <ng-container> | 
			
		
	
		
			
				
					|  |  |  |     <div *ngIf="size === 'large'"> | 
			
		
	
		
			
				
					|  |  |  |       <span class="h6" | 
			
		
	
		
			
				
					|  |  |  |         ><ng-container *ngTemplateOutlet="label"></ng-container | 
			
		
	
		
			
				
					|  |  |  |       ></span> | 
			
		
	
		
			
				
					|  |  |  |       <span *ngIf="subLabel" class="text-muted"> {{ subLabel }}</span> | 
			
		
	
		
			
				
					|  |  |  |     </div> | 
			
		
	
		
			
				
					|  |  |  |     <small *ngIf="size !== 'large'"> | 
			
		
	
		
			
				
					|  |  |  |       <ng-container *ngTemplateOutlet="label"></ng-container> | 
			
		
	
		
			
				
					|  |  |  |     </small> | 
			
		
	
		
			
				
					|  |  |  |   </ng-container> | 
			
		
	
		
			
				
					|  |  |  | </div> | 
			
		
	
	
		
			
				
					|  |  | 
 |