From 1f3ffdd2d60647a594a296e15a829ec691e8ae8f Mon Sep 17 00:00:00 2001 From: Attila Cseh Date: Tue, 22 Jul 2025 09:53:06 +0200 Subject: [PATCH] code review changes --- CHANGELOG.md | 7 ++++++- apps/client/src/app/app.component.ts | 4 ++-- libs/ui/.storybook/main.js | 1 + libs/ui/eslint.config.cjs | 4 ++-- .../lib/currency-selector/currency-selector.component.ts | 6 +++--- .../symbol-autocomplete/symbol-autocomplete.component.ts | 6 +++--- 6 files changed, 17 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f86829e32..73b8b33d4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,7 +22,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Improved the language localization for German (`de`) - Improved the language localization for Spanish (`es`) - Upgraded `countries-and-timezones` from version `3.7.2` to `3.8.0` -- Upgraded `Nx` from version `21.1.2` to `21.2.4` +- Upgraded `nx` from version `21.1.2` to `21.2.4` +- Upgraded `angular` from version `19.2.1` to `20.0.7` +- Upgraded `ngx-device-detector` from version `9.0.0` to `10.0.2` +- Upgraded `ngx-markdown` from version `19.0.0` to `20.0.0` +- Upgraded `ngx-stripe` from version `19.7.0` to `20.7.0` +- Upgraded `storybook` from version `8.6.12` to `9.0.17` ## 2.183.0 - 2025-07-20 diff --git a/apps/client/src/app/app.component.ts b/apps/client/src/app/app.component.ts index e5261a9f5..48a96511e 100644 --- a/apps/client/src/app/app.component.ts +++ b/apps/client/src/app/app.component.ts @@ -10,11 +10,11 @@ import { ChangeDetectionStrategy, ChangeDetectorRef, Component, + DOCUMENT, HostBinding, Inject, OnDestroy, - OnInit, - DOCUMENT + OnInit } from '@angular/core'; import { MatDialog } from '@angular/material/dialog'; import { Title } from '@angular/platform-browser'; diff --git a/libs/ui/.storybook/main.js b/libs/ui/.storybook/main.js index 03a92f74a..e7d1378c7 100644 --- a/libs/ui/.storybook/main.js +++ b/libs/ui/.storybook/main.js @@ -2,6 +2,7 @@ import { createRequire } from 'node:module'; import { dirname, join } from 'node:path'; const require = createRequire(import.meta.url); + /** @type {import('@storybook/angular').StorybookConfig} */ const config = { addons: [getAbsolutePath('@storybook/addon-docs')], diff --git a/libs/ui/eslint.config.cjs b/libs/ui/eslint.config.cjs index 8118924a1..e21452b5f 100644 --- a/libs/ui/eslint.config.cjs +++ b/libs/ui/eslint.config.cjs @@ -40,8 +40,8 @@ module.exports = [ style: 'kebab-case' } ], - '@angular-eslint/prefer-standalone': 'off', - '@angular-eslint/prefer-inject': 'off' + '@angular-eslint/prefer-inject': 'off', + '@angular-eslint/prefer-standalone': 'off' }, languageOptions: { parserOptions: { diff --git a/libs/ui/src/lib/currency-selector/currency-selector.component.ts b/libs/ui/src/lib/currency-selector/currency-selector.component.ts index 5afa50289..35a911716 100644 --- a/libs/ui/src/lib/currency-selector/currency-selector.component.ts +++ b/libs/ui/src/lib/currency-selector/currency-selector.component.ts @@ -4,12 +4,12 @@ import { ChangeDetectionStrategy, ChangeDetectorRef, Component, + DoCheck, ElementRef, Input, OnDestroy, OnInit, - ViewChild, - DoCheck + ViewChild } from '@angular/core'; import { FormControl, @@ -59,7 +59,7 @@ import { AbstractMatFormField } from '../shared/abstract-mat-form-field'; }) export class GfCurrencySelectorComponent extends AbstractMatFormField - implements OnInit, OnDestroy, DoCheck + implements DoCheck, OnDestroy, OnInit { @Input() private currencies: string[] = []; @Input() private formControlName: string; diff --git a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts index 45d80b52a..f6c289b72 100644 --- a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts +++ b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts @@ -8,14 +8,14 @@ import { ChangeDetectionStrategy, ChangeDetectorRef, Component, + DoCheck, ElementRef, Input, OnChanges, OnDestroy, OnInit, SimpleChanges, - ViewChild, - DoCheck + ViewChild } from '@angular/core'; import { FormControl, @@ -77,7 +77,7 @@ import { AbstractMatFormField } from '../shared/abstract-mat-form-field'; }) export class GfSymbolAutocompleteComponent extends AbstractMatFormField - implements OnChanges, OnDestroy, OnInit, DoCheck + implements DoCheck, OnChanges, OnDestroy, OnInit { @Input() public defaultLookupItems: LookupItem[] = []; @Input() public isLoading = false;