Remove symbol profile relation from activities

apps/api/src/app/activities/activities.controller.ts

@@ -36,6 +36,7 @@ import {
 import { Order, Prisma } from '@prisma/client';
 import { parseISO } from 'date-fns';
 import { StatusCodes, getReasonPhrase } from 'http-status-codes';
+import { omit } from 'lodash-es';
 
 import { ActivitiesFilterDto } from './activities-filter.dto';
 import { ActivitiesService } from './activities.service';
@@ -303,7 +304,7 @@ export class ActivitiesController {
       });
     }
 
-    return activity;
+    return omit(activity, ['SymbolProfile']);
   }
 
   @HasPermission(permissions.updateActivity)

apps/api/src/app/activities/activities.service.ts

@@ -60,7 +60,7 @@ import {
   Type as ActivityType
 } from '@prisma/client';
 import { Big } from 'big.js';
-import { groupBy, uniqBy } from 'lodash-es';
+import { groupBy, omit, uniqBy } from 'lodash-es';
 import { randomUUID } from 'node:crypto';
 
 @Injectable()
@@ -736,7 +736,7 @@ export class ActivitiesService {
         ]);
 
         return {
-          ...order,
+          ...omit(order, ['SymbolProfile']),
           assetProfile,
           feeInAssetProfileCurrency,
           feeInBaseCurrency,

apps/api/src/app/import/import.service.ts

@@ -1004,7 +1004,7 @@ export class ImportService {
         )) ?? 0;
 
       activities.push({
-        ...order,
+        ...omit(order, ['SymbolProfile']),
         // @ts-ignore
         assetProfile,
         error,

apps/api/src/helper/object.helper.spec.ts

@@ -3082,20 +3082,6 @@ describe('redactAttributes', () => {
           feeInBaseCurrency: 18.2,
           id: '8c623328-6035-4b5f-b6d5-702cc1c9c56b',
           quantity: 50,
-          // The relation of the database is part of the response next to the
-          // asset profile
-          SymbolProfile: {
-            comment: 'Reviewed by the administrator',
-            name: 'Apple Inc',
-            scraperConfiguration: {
-              headers: { Authorization: 'Bearer TOKEN' },
-              mode: 'lazy',
-              selector: '.price',
-              url: 'https://example.org/get_price'
-            },
-            symbol: 'AAPL',
-            symbolMapping: { YAHOO: 'AAPL' }
-          },
           type: 'BUY',
           unitPrice: 220.79,
           value: 11039.5,
@@ -3125,13 +3111,6 @@ describe('redactAttributes', () => {
       feeInBaseCurrency: null,
       id: '8c623328-6035-4b5f-b6d5-702cc1c9c56b',
       quantity: null,
-      SymbolProfile: {
-        comment: null,
-        name: 'Apple Inc',
-        scraperConfiguration: null,
-        symbol: 'AAPL',
-        symbolMapping: null
-      },
       type: 'BUY',
       // A price per unit stays visible, like the average price and the market
       // price of a holding
@@ -3190,18 +3169,6 @@ describe('redactAttributes', () => {
               currency: 'USD',
               fee: 19.9,
               quantity: 50,
-              SymbolProfile: {
-                comment: 'Reviewed by the administrator',
-                name: 'Apple Inc',
-                scraperConfiguration: {
-                  headers: { Authorization: 'Bearer TOKEN' },
-                  mode: 'lazy',
-                  selector: '.price',
-                  url: 'https://example.org/get_price'
-                },
-                symbol: 'AAPL',
-                symbolMapping: { YAHOO: 'AAPL' }
-              },
               type: 'BUY',
               unitPrice: 220.79,
               value: 11039.5,
@@ -3227,13 +3194,6 @@ describe('redactAttributes', () => {
           currency: 'USD',
           fee: null,
           quantity: null,
-          SymbolProfile: {
-            comment: null,
-            name: 'Apple Inc',
-            scraperConfiguration: null,
-            symbol: 'AAPL',
-            symbolMapping: null
-          },
           type: 'BUY',
           unitPrice: 220.79,
           value: null,

apps/api/src/interceptors/transform-data-source-in-response/transform-data-source-in-response.interceptor.ts

@@ -84,7 +84,6 @@ export class TransformDataSourceInResponseInterceptor<
               '["filters.dataSource"]',
               'activities[*].assetProfile.dataSource',
               'activities[*].dataSource',
-              'activities[*].SymbolProfile.dataSource',
               'assetProfile.dataSource',
               'benchmarks[*].dataSource',
               'errors[*].dataSource',
@@ -95,7 +94,6 @@ export class TransformDataSourceInResponseInterceptor<
               'items[*].dataSource',
               'latestActivities[*].assetProfile.dataSource',
               'settings["filters.dataSource"]',
-              'SymbolProfile.dataSource',
               'watchlist[*].dataSource'
             ]
           });

libs/common/src/lib/config.ts

@@ -138,9 +138,6 @@ export const DEFAULT_REDACTED_PATHS = [
   'activities[*].feeInAssetProfileCurrency',
   'activities[*].feeInBaseCurrency',
   'activities[*].quantity',
-  'activities[*].SymbolProfile.comment',
-  'activities[*].SymbolProfile.scraperConfiguration',
-  'activities[*].SymbolProfile.symbolMapping',
   'activities[*].value',
   'activities[*].valueInBaseCurrency',
   'assetProfile.comment',
@@ -183,9 +180,6 @@ export const DEFAULT_REDACTED_PATHS = [
   'settings.emergencyFund',
   'settings.projectedTotalAmount',
   'settings.savingsRate',
-  'SymbolProfile.comment',
-  'SymbolProfile.scraperConfiguration',
-  'SymbolProfile.symbolMapping',
   'totalBalanceInBaseCurrency',
   'totalDividendInBaseCurrency',
   'totalInterestInBaseCurrency',