From 2765fb1df7e7ff4589ef0d90a495c739457cc801 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Tue, 25 Nov 2025 16:57:24 +0100
Subject: [PATCH] Task/refactor from v4 as uuidv4 from uuid to
 crypto.randomUUID() (#5990)

* Refactor from v4 as uuidv4 from uuid to randomUUID() from node:crypto

* Update changelog
---
 CHANGELOG.md                               | 4 ++++
 apps/api/src/app/import/import.service.ts  | 6 +++---
 apps/api/src/app/order/order.service.ts    | 4 ++--
 apps/api/src/services/demo/demo.service.ts | 4 ++--
 package-lock.json                          | 2 +-
 package.json                               | 1 -
 6 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9538fc92f..7c70f99b7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Changed
+
+- Eliminated `uuid` in favor of using `randomUUID` from `node:crypto`
+
 ### Fixed
 
 - Fixed an issue with the exchange rate calculation when converting between derived currencies and their root currencies
diff --git a/apps/api/src/app/import/import.service.ts b/apps/api/src/app/import/import.service.ts
index a5f3dda96..2deef1c44 100644
--- a/apps/api/src/app/import/import.service.ts
+++ b/apps/api/src/app/import/import.service.ts
@@ -35,7 +35,7 @@ import { DataSource, Prisma, SymbolProfile } from '@prisma/client';
 import { Big } from 'big.js';
 import { endOfToday, isAfter, isSameSecond, parseISO } from 'date-fns';
 import { omit, uniqBy } from 'lodash';
-import { v4 as uuidv4 } from 'uuid';
+import { randomUUID } from 'node:crypto';
 
 import { ImportDataDto } from './import-data.dto';
 
@@ -277,7 +277,7 @@ export class ImportService {
 
           // Asset profile belongs to a different user
           if (existingAssetProfile) {
-            const symbol = uuidv4();
+            const symbol = randomUUID();
             assetProfileSymbolMapping[assetProfile.symbol] = symbol;
             assetProfile.symbol = symbol;
           }
@@ -496,7 +496,7 @@ export class ImportService {
           accountId: validatedAccount?.id,
           accountUserId: undefined,
           createdAt: new Date(),
-          id: uuidv4(),
+          id: randomUUID(),
           isDraft: isAfter(date, endOfToday()),
           SymbolProfile: {
             assetClass,
diff --git a/apps/api/src/app/order/order.service.ts b/apps/api/src/app/order/order.service.ts
index 7dc6c646d..001d43b7a 100644
--- a/apps/api/src/app/order/order.service.ts
+++ b/apps/api/src/app/order/order.service.ts
@@ -37,7 +37,7 @@ import { Big } from 'big.js';
 import { isUUID } from 'class-validator';
 import { endOfToday, isAfter } from 'date-fns';
 import { groupBy, uniqBy } from 'lodash';
-import { v4 as uuidv4 } from 'uuid';
+import { randomUUID } from 'node:crypto';
 
 @Injectable()
 export class OrderService {
@@ -143,7 +143,7 @@ export class OrderService {
       } else {
         // Create custom asset profile
         name = name ?? data.SymbolProfile.connectOrCreate.create.symbol;
-        symbol = uuidv4();
+        symbol = randomUUID();
       }
 
       data.SymbolProfile.connectOrCreate.create.assetClass = assetClass;
diff --git a/apps/api/src/services/demo/demo.service.ts b/apps/api/src/services/demo/demo.service.ts
index 8f3658736..a24716d96 100644
--- a/apps/api/src/services/demo/demo.service.ts
+++ b/apps/api/src/services/demo/demo.service.ts
@@ -7,7 +7,7 @@ import {
 } from '@ghostfolio/common/config';
 
 import { Injectable } from '@nestjs/common';
-import { v4 as uuidv4 } from 'uuid';
+import { randomUUID } from 'node:crypto';
 
 @Injectable()
 export class DemoService {
@@ -41,7 +41,7 @@ export class DemoService {
         accountId: demoAccountId,
         accountUserId: demoUserId,
         comment: null,
-        id: uuidv4(),
+        id: randomUUID(),
         userId: demoUserId
       };
     });
diff --git a/package-lock.json b/package-lock.json
index e798cc3b9..993413fa9 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -89,7 +89,6 @@
         "svgmap": "2.14.0",
         "tablemark": "4.1.0",
         "twitter-api-v2": "1.27.0",
-        "uuid": "11.1.0",
         "yahoo-finance2": "3.10.2",
         "zone.js": "0.15.1"
       },
@@ -40596,6 +40595,7 @@
         "https://github.com/sponsors/ctavan"
       ],
       "license": "MIT",
+      "optional": true,
       "bin": {
         "uuid": "dist/esm/bin/uuid"
       }
diff --git a/package.json b/package.json
index edce75afe..7f66f0edd 100644
--- a/package.json
+++ b/package.json
@@ -135,7 +135,6 @@
     "svgmap": "2.14.0",
     "tablemark": "4.1.0",
     "twitter-api-v2": "1.27.0",
-    "uuid": "11.1.0",
     "yahoo-finance2": "3.10.2",
     "zone.js": "0.15.1"
   },