From 29bae6950513d194643dc46fa3f257affd7edf69 Mon Sep 17 00:00:00 2001 From: Neel Date: Sun, 5 Jul 2026 13:37:49 +0530 Subject: [PATCH] migrated + changelog --- CHANGELOG.md | 6 ++++++ .../notifications/alert-dialog/alert-dialog.component.ts | 3 ++- .../confirmation-dialog/confirmation-dialog.component.ts | 8 +++++++- .../prompt-dialog/prompt-dialog.component.ts | 3 ++- 4 files changed, 17 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 873017336e..5d864efba3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,9 +13,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed +<<<<<<< HEAD - Set the change detection strategy to OnPush in the X-ray page - Retained the existing `markForCheck()` calls for user and portfolio report subscriptions - Reduced unnecessary change detection cycles in the X-ray portfolio view +======= +- Set the change detection strategy to `OnPush` in the alert dialog component +- Set the change detection strategy to `OnPush` in the confirmation dialog component +- Set the change detection strategy to `OnPush` in the prompt dialog component +>>>>>>> 3ea21707b0bcbae604d9260858b5e1b7ccbf10ef - Upgraded `stripe` from version `21.0.1` to `22.2.3` ### Fixed diff --git a/libs/ui/src/lib/notifications/alert-dialog/alert-dialog.component.ts b/libs/ui/src/lib/notifications/alert-dialog/alert-dialog.component.ts index 5d49ea9e51..3dbe703870 100644 --- a/libs/ui/src/lib/notifications/alert-dialog/alert-dialog.component.ts +++ b/libs/ui/src/lib/notifications/alert-dialog/alert-dialog.component.ts @@ -1,10 +1,11 @@ -import { Component, inject } from '@angular/core'; +import { ChangeDetectionStrategy, Component, inject } from '@angular/core'; import { MatButtonModule } from '@angular/material/button'; import { MatDialogModule, MatDialogRef } from '@angular/material/dialog'; import { AlertDialogParams } from './interfaces/interfaces'; @Component({ + changeDetection: ChangeDetectionStrategy.OnPush, imports: [MatButtonModule, MatDialogModule], selector: 'gf-alert-dialog', styleUrls: ['./alert-dialog.scss'], diff --git a/libs/ui/src/lib/notifications/confirmation-dialog/confirmation-dialog.component.ts b/libs/ui/src/lib/notifications/confirmation-dialog/confirmation-dialog.component.ts index 0ae0adfff5..38509ea99c 100644 --- a/libs/ui/src/lib/notifications/confirmation-dialog/confirmation-dialog.component.ts +++ b/libs/ui/src/lib/notifications/confirmation-dialog/confirmation-dialog.component.ts @@ -1,12 +1,18 @@ import { ConfirmationDialogType } from '@ghostfolio/common/enums'; -import { Component, HostListener, inject } from '@angular/core'; +import { + ChangeDetectionStrategy, + Component, + HostListener, + inject +} from '@angular/core'; import { MatButtonModule } from '@angular/material/button'; import { MatDialogModule, MatDialogRef } from '@angular/material/dialog'; import { ConfirmDialogParams } from './interfaces/interfaces'; @Component({ + changeDetection: ChangeDetectionStrategy.OnPush, imports: [MatButtonModule, MatDialogModule], selector: 'gf-confirmation-dialog', styleUrls: ['./confirmation-dialog.scss'], diff --git a/libs/ui/src/lib/notifications/prompt-dialog/prompt-dialog.component.ts b/libs/ui/src/lib/notifications/prompt-dialog/prompt-dialog.component.ts index 2205e235c2..e9750c3f52 100644 --- a/libs/ui/src/lib/notifications/prompt-dialog/prompt-dialog.component.ts +++ b/libs/ui/src/lib/notifications/prompt-dialog/prompt-dialog.component.ts @@ -1,4 +1,4 @@ -import { Component, inject } from '@angular/core'; +import { ChangeDetectionStrategy, Component, inject } from '@angular/core'; import { FormControl, ReactiveFormsModule } from '@angular/forms'; import { MatButtonModule } from '@angular/material/button'; import { MatDialogModule, MatDialogRef } from '@angular/material/dialog'; @@ -8,6 +8,7 @@ import { MatInputModule } from '@angular/material/input'; import { PromptDialogParams } from './interfaces/interfaces'; @Component({ + changeDetection: ChangeDetectionStrategy.OnPush, imports: [ MatButtonModule, MatDialogModule,