chore(fire): Small fixes based on PR comments

apps/client/src/app/pages/portfolio/fire/fire-page.component.ts

@@ -39,6 +39,7 @@ export class FirePageComponent implements OnDestroy, OnInit {
   public ngOnInit() {
     this.isLoading = true;
     this.deviceType = this.deviceService.getDeviceInfo().deviceType;
+
     this.dataService
       .fetchPortfolioDetails({})
       .pipe(takeUntil(this.unsubscribeSubject))

libs/ui/src/lib/fire-calculator/fire-calculator.component.ts

@@ -62,8 +62,8 @@ export class FireCalculatorComponent
     annualInterestRate: new FormControl<number>(undefined),
     paymentPerPeriod: new FormControl<number>(undefined),
     principalInvestmentAmount: new FormControl<number>(undefined),
-    time: new FormControl<number>(undefined),
+    retirementNetWorth: new FormControl<number>(undefined),
-    retirementNetWorth: new FormControl<number>(undefined)
+    time: new FormControl<number>(undefined)
   });
   public chart: Chart<'bar'>;
   public isLoading = true;
@@ -91,8 +91,8 @@ export class FireCalculatorComponent
         annualInterestRate: 5,
         paymentPerPeriod: this.savingsRate,
         principalInvestmentAmount: 0,
-        time: 10,
+        retirementNetWorth: this.targetNetWorth,
-        retirementNetWorth: this.targetNetWorth
+        time: 10
       },
       {
         emitEvent: false

libs/ui/src/lib/fire-calculator/fire-calculator.service.spec.ts

@@ -16,10 +16,6 @@ describe('FireCalculatorService', () => {
     );
   });
 
-  it('true', async () => {
-    expect(true).toBe(true);
-  });
-
   describe('Test periods to retire', () => {
     it('should return the correct amount of periods to retire with no interst rate', async () => {
       const r = 0;

libs/ui/src/lib/fire-calculator/fire-calculator.service.ts

@@ -53,7 +53,7 @@ export class FireCalculatorService {
     totalAmount: number;
   }) {
     if (r == 0) {
-      //No compound interest
+      // No compound interest
       return (totalAmount - P) / PMT;
     } else if (totalAmount <= 0) {
       return 0;