diff --git a/apps/api/src/app/order/order.controller.ts b/apps/api/src/app/order/order.controller.ts index 7e225c90b..0f1e382d6 100644 --- a/apps/api/src/app/order/order.controller.ts +++ b/apps/api/src/app/order/order.controller.ts @@ -41,15 +41,11 @@ export class OrderController { @Inject(REQUEST) private readonly request: RequestWithUser ) {} - @Delete(':id') + @Delete() @UseGuards(AuthGuard('jwt')) - public async deleteOrder(@Param('id') id: string): Promise { - const order = await this.orderService.order({ id }); - + public async deleteOrders(): Promise { if ( - !hasPermission(this.request.user.permissions, permissions.deleteOrder) || - !order || - order.userId !== this.request.user.id + !hasPermission(this.request.user.permissions, permissions.deleteOrder) ) { throw new HttpException( getReasonPhrase(StatusCodes.FORBIDDEN), @@ -57,16 +53,20 @@ export class OrderController { ); } - return this.orderService.deleteOrder({ - id + return this.orderService.deleteOrders({ + userId: this.request.user.id }); } - @Delete() + @Delete(':id') @UseGuards(AuthGuard('jwt')) - public async deleteOrders(): Promise { + public async deleteOrder(@Param('id') id: string): Promise { + const order = await this.orderService.order({ id }); + if ( - !hasPermission(this.request.user.permissions, permissions.deleteOrder) + !hasPermission(this.request.user.permissions, permissions.deleteOrder) || + !order || + order.userId !== this.request.user.id ) { throw new HttpException( getReasonPhrase(StatusCodes.FORBIDDEN), @@ -74,8 +74,8 @@ export class OrderController { ); } - return this.orderService.deleteOrders({ - userId: this.request.user.id + return this.orderService.deleteOrder({ + id }); } diff --git a/apps/client/src/app/services/data.service.ts b/apps/client/src/app/services/data.service.ts index 327934aab..bff672717 100644 --- a/apps/client/src/app/services/data.service.ts +++ b/apps/client/src/app/services/data.service.ts @@ -146,14 +146,14 @@ export class DataService { return this.http.delete(`/api/v1/account/${aId}`); } - public deleteOrder(aId: string) { - return this.http.delete(`/api/v1/order/${aId}`); - } - public deleteAllOrders() { return this.http.delete(`/api/v1/order/`); } + public deleteOrder(aId: string) { + return this.http.delete(`/api/v1/order/${aId}`); + } + public deleteUser(aId: string) { return this.http.delete(`/api/v1/user/${aId}`); } diff --git a/libs/ui/src/lib/activities-table/activities-table.component.html b/libs/ui/src/lib/activities-table/activities-table.component.html index 6fde05861..4ac853436 100644 --- a/libs/ui/src/lib/activities-table/activities-table.component.html +++ b/libs/ui/src/lib/activities-table/activities-table.component.html @@ -59,7 +59,7 @@ (click)="onDeleteAllActivities()" > - Delete all activities + Delete all Activities diff --git a/libs/ui/src/lib/activities-table/activities-table.component.ts b/libs/ui/src/lib/activities-table/activities-table.component.ts index 78d270827..1c3fb0367 100644 --- a/libs/ui/src/lib/activities-table/activities-table.component.ts +++ b/libs/ui/src/lib/activities-table/activities-table.component.ts @@ -49,10 +49,10 @@ export class ActivitiesTableComponent implements OnChanges, OnDestroy, OnInit { @Output() activityDeleted = new EventEmitter(); @Output() activityToClone = new EventEmitter(); @Output() activityToUpdate = new EventEmitter(); + @Output() deleteAllActivities = new EventEmitter(); @Output() export = new EventEmitter(); @Output() exportDrafts = new EventEmitter(); @Output() import = new EventEmitter(); - @Output() deleteAllActivities = new EventEmitter(); @Output() importDividends = new EventEmitter(); @Output() selectedActivities = new EventEmitter();