Merge branch 'main' into fix/fix-import-by-isin-number

CHANGELOG.md

@@ -11,6 +11,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Improved the activities import by `isin` in the _Yahoo Finance_ service
 
+## 2.58.0 - 2024-02-27
+
+### Changed
+
+- Improved the handling of activities without account
+
+### Fixed
+
+- Fixed the query to filter activities of excluded accounts
+- Improved the asset profile validation in the activities import
+
 ## 2.57.0 - 2024-02-25
 
 ### Changed

apps/api/src/app/import/import.service.ts

@@ -570,17 +570,10 @@ export class ImportService {
       [assetProfileIdentifier: string]: Partial<SymbolProfile>;
     } = {};
 
-    const uniqueActivitiesDto = uniqBy(
-      activitiesDto,
-      ({ dataSource, symbol }) => {
-        return getAssetProfileIdentifier({ dataSource, symbol });
-      }
-    );
-
     for (const [
       index,
       { currency, dataSource, symbol, type }
-    ] of uniqueActivitiesDto.entries()) {
+    ] of activitiesDto.entries()) {
       if (!this.configurationService.get('DATA_SOURCES').includes(dataSource)) {
         throw new Error(
           `activities.${index}.dataSource ("${dataSource}") is not valid`
@@ -602,37 +595,33 @@ export class ImportService {
         }
       }
 
-      const assetProfile = {
+      if (!assetProfiles[getAssetProfileIdentifier({ dataSource, symbol })]) {
-        currency,
+        const assetProfile = {
-        ...(
+          currency,
-          await this.dataProviderService.getAssetProfiles([
+          ...(
-            { dataSource, symbol }
+            await this.dataProviderService.getAssetProfiles([
-          ])
+              { dataSource, symbol }
-        )?.[symbol]
+            ])
-      };
+          )?.[symbol]
+        };
 
-      if (type === 'BUY' || type === 'DIVIDEND' || type === 'SELL') {
+        if (type === 'BUY' || type === 'DIVIDEND' || type === 'SELL') {
-        if (!assetProfile?.name) {
+          if (!assetProfile?.name) {
-          throw new Error(
+            throw new Error(
-            `activities.${index}.symbol ("${symbol}") is not valid for the specified data source ("${dataSource}")`
+              `activities.${index}.symbol ("${symbol}") is not valid for the specified data source ("${dataSource}")`
-          );
+            );
-        }
+          }
 
-        if (
+          if (assetProfile.currency !== currency) {
-          assetProfile.currency !== currency &&
+            throw new Error(
-          !this.exchangeRateDataService.hasCurrencyPair(
+              `activities.${index}.currency ("${currency}") does not match with currency of ${assetProfile.symbol} ("${assetProfile.currency}")`
-            currency,
+            );
-            assetProfile.currency
+          }
-          )
-        ) {
-          throw new Error(
-            `activities.${index}.currency ("${currency}") does not match with "${assetProfile.currency}" and no exchange rate is available from "${currency}" to "${assetProfile.currency}"`
-          );
         }
-      }
 
-      assetProfiles[getAssetProfileIdentifier({ dataSource, symbol })] =
+        assetProfiles[getAssetProfileIdentifier({ dataSource, symbol })] =
-        assetProfile;
+          assetProfile;
+      }
     }
 
     return assetProfiles;

apps/api/src/app/order/order.service.ts

@@ -292,19 +292,14 @@ export class OrderService {
     }
 
     if (types) {
-      where.OR = types.map((type) => {
+      where.type = { in: types };
-        return {
-          type: {
-            equals: type
-          }
-        };
-      });
     }
 
     if (withExcludedAccounts === false) {
-      where.Account = {
+      where.OR = [
-        NOT: { isExcluded: true }
+        { Account: null },
-      };
+        { Account: { NOT: { isExcluded: true } } }
+      ];
     }
 
     const [orders, count] = await Promise.all([

apps/api/src/app/portfolio/portfolio.service.ts

@@ -749,7 +749,9 @@ export class PortfolioService {
       } = position;
 
       const accounts: PortfolioPositionDetail['accounts'] = uniqBy(
-        orders,
+        orders.filter(({ Account }) => {
+          return Account;
+        }),
         'Account.id'
       ).map(({ Account }) => {
         return Account;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ghostfolio",
-  "version": "2.57.0",
+  "version": "2.58.0",
   "homepage": "https://ghostfol.io",
   "license": "AGPL-3.0",
   "repository": "https://github.com/ghostfolio/ghostfolio",