Browse Source

Unsubscribe to observable once component is destroyed

pull/1531/head
yksolanki9 3 years ago
parent
commit
2d6d31623b
  1. 4
      apps/client/src/app/services/import-activities.service.ts
  2. 8
      libs/ui/src/lib/activities-table/activities-table.component.ts

4
apps/client/src/app/services/import-activities.service.ts

@ -79,8 +79,8 @@ export class ImportActivitiesService {
}) })
) )
.subscribe({ .subscribe({
next: (importedActivities) => { next: (data) => {
resolve(importedActivities.activities); resolve(data.activities);
} }
}); });
}); });

8
libs/ui/src/lib/activities-table/activities-table.component.ts

@ -164,9 +164,11 @@ export class ActivitiesTableComponent implements OnChanges, OnDestroy {
} }
ngOnInit() { ngOnInit() {
this.selectedRows.changed.subscribe((selectedRows) => { this.selectedRows.changed
this.selectedActivities.emit(selectedRows.source.selected); .pipe(takeUntil(this.unsubscribeSubject))
}); .subscribe((selectedRows) => {
this.selectedActivities.emit(selectedRows.source.selected);
});
} }
public onChangePage(page: PageEvent) { public onChangePage(page: PageEvent) {

Loading…
Cancel
Save