Browse Source
Feature/Remove empty constructors (#3958)
* Remove empty constructors
pull/3962/head
Thomas Kaul
3 months ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
32 changed files with
1 additions and
65 deletions
-
apps/api/src/app/portfolio/rules.service.ts
-
apps/api/src/interceptors/redact-values-in-response/redact-values-in-response.interceptor.ts
-
apps/api/src/services/api/api.service.ts
-
apps/api/src/services/cryptocurrency/cryptocurrency.service.ts
-
apps/client/src/app/components/asset-profile-icon/asset-profile-icon.component.ts
-
apps/client/src/app/components/dialog-footer/dialog-footer.component.ts
-
apps/client/src/app/components/dialog-header/dialog-header.component.ts
-
apps/client/src/app/components/fear-and-greed-index/fear-and-greed-index.component.ts
-
apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts
-
apps/client/src/app/components/toggle/toggle.component.ts
-
apps/client/src/app/core/language.service.ts
-
apps/client/src/app/pages/about/changelog/changelog-page.component.ts
-
apps/client/src/app/pages/about/license/license-page.component.ts
-
apps/client/src/app/pages/about/oss-friends/oss-friends-page.component.ts
-
apps/client/src/app/pages/about/privacy-policy/privacy-policy-page.component.ts
-
apps/client/src/app/pages/faq/self-hosting/self-hosting-page.component.ts
-
apps/client/src/app/pages/i18n/i18n-page.component.ts
-
apps/client/src/app/pages/markets/markets-page.component.ts
-
apps/client/src/app/pages/resources/personal-finance-tools/personal-finance-tools-page.component.ts
-
apps/client/src/app/pipes/symbol/symbol.pipe.ts
-
apps/client/src/app/services/ics/ics.service.ts
-
apps/client/src/app/services/impersonation-storage.service.ts
-
apps/client/src/app/services/settings-storage.service.ts
-
libs/ui/src/lib/activity-type/activity-type.component.ts
-
libs/ui/src/lib/data-provider-credits/data-provider-credits.component.ts
-
libs/ui/src/lib/fire-calculator/fire-calculator.service.ts
-
libs/ui/src/lib/holdings-table/holdings-table.component.ts
-
libs/ui/src/lib/logo/logo.component.ts
-
libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts
-
libs/ui/src/lib/premium-indicator/premium-indicator.component.ts
-
libs/ui/src/lib/trend-indicator/trend-indicator.component.ts
-
libs/ui/src/lib/value/value.component.ts
|
|
@ -9,8 +9,6 @@ import { Injectable } from '@nestjs/common'; |
|
|
|
|
|
|
|
@Injectable() |
|
|
|
export class RulesService { |
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public async evaluate<T extends RuleSettings>( |
|
|
|
aRules: Rule<T>[], |
|
|
|
aUserSettings: UserSettings |
|
|
|
|
|
@ -19,8 +19,6 @@ import { map } from 'rxjs/operators'; |
|
|
|
export class RedactValuesInResponseInterceptor<T> |
|
|
|
implements NestInterceptor<T, any> |
|
|
|
{ |
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public intercept( |
|
|
|
context: ExecutionContext, |
|
|
|
next: CallHandler<T> |
|
|
|
|
|
@ -4,8 +4,6 @@ import { Injectable } from '@nestjs/common'; |
|
|
|
|
|
|
|
@Injectable() |
|
|
|
export class ApiService { |
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public buildFiltersFromQueryParams({ |
|
|
|
filterByAccounts, |
|
|
|
filterByAssetClasses, |
|
|
|
|
|
@ -7,8 +7,6 @@ const customCryptocurrencies = require('../../assets/cryptocurrencies/custom.jso |
|
|
|
export class CryptocurrencyService { |
|
|
|
private combinedCryptocurrencies: string[]; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public isCryptocurrency(aSymbol = '') { |
|
|
|
const cryptocurrencySymbol = aSymbol.substring(0, aSymbol.length - 3); |
|
|
|
return this.getCryptocurrencies().includes(cryptocurrencySymbol); |
|
|
|
|
|
@ -26,8 +26,6 @@ export class GfAssetProfileIconComponent implements OnChanges { |
|
|
|
|
|
|
|
public src: string; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnChanges() { |
|
|
|
if (this.dataSource && this.symbol) { |
|
|
|
this.src = `../api/v1/logo/${this.dataSource}/${this.symbol}`; |
|
|
|
|
|
@ -19,8 +19,6 @@ export class DialogFooterComponent implements OnInit { |
|
|
|
|
|
|
|
@Output() closeButtonClicked = new EventEmitter<void>(); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnInit() {} |
|
|
|
|
|
|
|
public onClickCloseButton() { |
|
|
|
|
|
@ -21,8 +21,6 @@ export class DialogHeaderComponent implements OnInit { |
|
|
|
|
|
|
|
@Output() closeButtonClicked = new EventEmitter<void>(); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnInit() {} |
|
|
|
|
|
|
|
public onClickCloseButton() { |
|
|
|
|
|
@ -21,8 +21,6 @@ export class FearAndGreedIndexComponent implements OnChanges, OnInit { |
|
|
|
public fearAndGreedIndexEmoji: string; |
|
|
|
public fearAndGreedIndexText: string; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnInit() {} |
|
|
|
|
|
|
|
public ngOnChanges() { |
|
|
|
|
|
@ -35,8 +35,6 @@ export class PortfolioSummaryComponent implements OnChanges, OnInit { |
|
|
|
); |
|
|
|
public timeInMarket: string; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnInit() {} |
|
|
|
|
|
|
|
public ngOnChanges() { |
|
|
|
|
|
@ -34,8 +34,6 @@ export class ToggleComponent implements OnChanges, OnInit { |
|
|
|
|
|
|
|
public optionFormControl = new FormControl<string>(undefined); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnInit() {} |
|
|
|
|
|
|
|
public ngOnChanges() { |
|
|
|
|
|
@ -1,6 +1,4 @@ |
|
|
|
import { Injectable } from '@angular/core'; |
|
|
|
|
|
|
|
@Injectable() |
|
|
|
export class LanguageService { |
|
|
|
public constructor() {} |
|
|
|
} |
|
|
|
export class LanguageService {} |
|
|
|
|
|
@ -9,8 +9,6 @@ import { Subject } from 'rxjs'; |
|
|
|
export class ChangelogPageComponent implements OnDestroy { |
|
|
|
private unsubscribeSubject = new Subject<void>(); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnDestroy() { |
|
|
|
this.unsubscribeSubject.next(); |
|
|
|
this.unsubscribeSubject.complete(); |
|
|
|
|
|
@ -9,8 +9,6 @@ import { Subject } from 'rxjs'; |
|
|
|
export class LicensePageComponent implements OnDestroy { |
|
|
|
private unsubscribeSubject = new Subject<void>(); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnDestroy() { |
|
|
|
this.unsubscribeSubject.next(); |
|
|
|
this.unsubscribeSubject.complete(); |
|
|
|
|
|
@ -13,8 +13,6 @@ export class OpenSourceSoftwareFriendsPageComponent implements OnDestroy { |
|
|
|
|
|
|
|
private unsubscribeSubject = new Subject<void>(); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnDestroy() { |
|
|
|
this.unsubscribeSubject.next(); |
|
|
|
this.unsubscribeSubject.complete(); |
|
|
|
|
|
@ -9,8 +9,6 @@ import { Subject } from 'rxjs'; |
|
|
|
export class PrivacyPolicyPageComponent implements OnDestroy { |
|
|
|
private unsubscribeSubject = new Subject<void>(); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnDestroy() { |
|
|
|
this.unsubscribeSubject.next(); |
|
|
|
this.unsubscribeSubject.complete(); |
|
|
|
|
|
@ -10,8 +10,6 @@ import { Subject } from 'rxjs'; |
|
|
|
export class SelfHostingPageComponent implements OnDestroy { |
|
|
|
private unsubscribeSubject = new Subject<void>(); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnInit() {} |
|
|
|
|
|
|
|
public ngOnDestroy() { |
|
|
|
|
|
@ -11,8 +11,6 @@ import { Subject } from 'rxjs'; |
|
|
|
export class GfI18nPageComponent implements OnInit { |
|
|
|
private unsubscribeSubject = new Subject<void>(); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnInit() {} |
|
|
|
|
|
|
|
public ngOnDestroy() { |
|
|
|
|
|
@ -10,8 +10,6 @@ import { Subject } from 'rxjs'; |
|
|
|
export class MarketsPageComponent implements OnDestroy, OnInit { |
|
|
|
private unsubscribeSubject = new Subject<void>(); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnInit() {} |
|
|
|
|
|
|
|
public ngOnDestroy() { |
|
|
|
|
|
@ -19,8 +19,6 @@ export class PersonalFinanceToolsPageComponent implements OnDestroy { |
|
|
|
|
|
|
|
private unsubscribeSubject = new Subject<void>(); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnDestroy() { |
|
|
|
this.unsubscribeSubject.next(); |
|
|
|
this.unsubscribeSubject.complete(); |
|
|
|
|
|
@ -4,8 +4,6 @@ import { Pipe, PipeTransform } from '@angular/core'; |
|
|
|
|
|
|
|
@Pipe({ name: 'gfSymbol' }) |
|
|
|
export class SymbolPipe implements PipeTransform { |
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public transform(aSymbol: string) { |
|
|
|
return prettifySymbol(aSymbol); |
|
|
|
} |
|
|
|
|
|
@ -12,8 +12,6 @@ export class IcsService { |
|
|
|
private readonly ICS_DATE_FORMAT = 'yyyyMMdd'; |
|
|
|
private readonly ICS_LINE_BREAK = '\r\n'; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public transformActivitiesToIcsContent( |
|
|
|
aActivities: Export['activities'] |
|
|
|
): string { |
|
|
|
|
|
@ -11,8 +11,6 @@ export class ImpersonationStorageService { |
|
|
|
this.getId() |
|
|
|
); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public getId(): string { |
|
|
|
return window.localStorage.getItem(IMPERSONATION_KEY); |
|
|
|
} |
|
|
|
|
|
@ -8,8 +8,6 @@ export const KEY_TOKEN = 'auth-token'; |
|
|
|
providedIn: 'root' |
|
|
|
}) |
|
|
|
export class SettingsStorageService { |
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public getSetting(aKey: string): string { |
|
|
|
return window.localStorage.getItem(aKey); |
|
|
|
} |
|
|
|
|
|
@ -24,8 +24,6 @@ export class GfActivityTypeComponent implements OnChanges { |
|
|
|
|
|
|
|
public activityTypeLabel: string; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnChanges() { |
|
|
|
this.activityTypeLabel = translate(this.activityType); |
|
|
|
} |
|
|
|
|
|
@ -19,6 +19,4 @@ import { |
|
|
|
}) |
|
|
|
export class GfDataProviderCreditsComponent { |
|
|
|
@Input() dataProviderInfos: DataProviderInfo[]; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
} |
|
|
|
|
|
@ -5,8 +5,6 @@ import { Big } from 'big.js'; |
|
|
|
export class FireCalculatorService { |
|
|
|
private readonly COMPOUND_PERIOD = 12; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public calculateCompoundInterest({ |
|
|
|
P, |
|
|
|
periodInMonths, |
|
|
|
|
|
@ -76,8 +76,6 @@ export class GfHoldingsTableComponent implements OnChanges, OnDestroy { |
|
|
|
|
|
|
|
private unsubscribeSubject = new Subject<void>(); |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnChanges() { |
|
|
|
this.displayedColumns = ['icon', 'nameWithSymbol', 'dateOfFirstActivity']; |
|
|
|
|
|
|
|
|
|
@ -20,6 +20,4 @@ export class GfLogoComponent { |
|
|
|
@HostBinding('class') @Input() size: 'large' | 'medium' = 'medium'; |
|
|
|
@Input() label: string; |
|
|
|
@Input() showLabel = true; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
} |
|
|
|
|
|
@ -21,6 +21,4 @@ import { GfLogoComponent } from '../logo'; |
|
|
|
}) |
|
|
|
export class GfNoTransactionsInfoComponent { |
|
|
|
@HostBinding('class.has-border') @Input() hasBorder = true; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
} |
|
|
|
|
|
@ -18,6 +18,4 @@ import { RouterModule } from '@angular/router'; |
|
|
|
}) |
|
|
|
export class GfPremiumIndicatorComponent { |
|
|
|
@Input() enableLink = true; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
} |
|
|
|
|
|
@ -24,6 +24,4 @@ export class GfTrendIndicatorComponent { |
|
|
|
@Input() marketState: MarketState = 'open'; |
|
|
|
@Input() size: 'large' | 'medium' | 'small' = 'small'; |
|
|
|
@Input() value = 0; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
} |
|
|
|
|
|
@ -41,8 +41,6 @@ export class GfValueComponent implements OnChanges { |
|
|
|
public isString = false; |
|
|
|
public useAbsoluteValue = false; |
|
|
|
|
|
|
|
public constructor() {} |
|
|
|
|
|
|
|
public ngOnChanges() { |
|
|
|
this.initializeVariables(); |
|
|
|
|
|
|
|