From 31e742b8225eb1b79994f239d6363b9a12536d00 Mon Sep 17 00:00:00 2001
From: csehatt741 <att741@gmail.com>
Date: Thu, 12 Jun 2025 08:48:42 +0200
Subject: [PATCH] Code review fixes

---
 ...ate-or-update-activity-dialog.component.ts | 38 +++++++++++--------
 .../symbol-autocomplete.component.ts          |  3 +-
 2 files changed, 24 insertions(+), 17 deletions(-)

diff --git a/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts b/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts
index f65d551a5..56575adb5 100644
--- a/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts
+++ b/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts
@@ -96,22 +96,28 @@ export class CreateOrUpdateActivityDialog implements OnDestroy {
           .sort((a, b) => {
             return a.name?.localeCompare(b.name);
           })
-          .map((holding) => {
-            return {
-              assetClass: holding.assetClass,
-              assetSubClass: holding.assetSubClass,
-              currency: holding.currency,
-              dataProviderInfo: {
-                dataSource: holding.dataSource,
-                isPremium: false,
-                name: holding.name,
-                url: holding.url
-              },
-              dataSource: holding.dataSource,
-              name: holding.name,
-              symbol: holding.symbol
-            };
-          });
+          .map(
+            ({
+              assetClass,
+              assetSubClass,
+              currency,
+              dataSource,
+              name,
+              symbol
+            }) => {
+              return {
+                assetClass,
+                assetSubClass,
+                currency,
+                dataProviderInfo: {
+                  isPremium: false
+                },
+                dataSource,
+                name,
+                symbol
+              };
+            }
+          );
       });
 
     this.tagsAvailable =
diff --git a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts
index ff14f30e1..4fb974c54 100644
--- a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts
+++ b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts
@@ -12,6 +12,7 @@ import {
   Component,
   ElementRef,
   Input,
+  OnChanges,
   OnDestroy,
   OnInit,
   SimpleChanges,
@@ -75,7 +76,7 @@ import { GfPremiumIndicatorComponent } from '../premium-indicator';
 })
 export class GfSymbolAutocompleteComponent
   extends AbstractMatFormField<LookupItem>
-  implements OnInit, OnDestroy
+  implements OnChanges, OnDestroy, OnInit
 {
   @Input() public defaultLookupItems: LookupItem[] = [];
   @Input() public isLoading = false;