From 3220b017e17f22b11000ab2c14a24a194108bb8d Mon Sep 17 00:00:00 2001 From: Aftab3008 Date: Sun, 5 Jul 2026 21:57:26 +0530 Subject: [PATCH] Task: Added changelogs and improved code readability --- CHANGELOG.md | 6 ++++++ apps/api/src/app/admin/admin.service.ts | 4 ++-- apps/api/src/app/admin/pipes/property-key.pipe.ts | 10 +++++++--- 3 files changed, 15 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index df95d849b..bf0343262 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## Unreleased + +### Changed + +- Hardened the endpoint to update a property of the admin control panel by validating the `key` path parameter + ## 3.21.0 - 2026-07-05 ### Added diff --git a/apps/api/src/app/admin/admin.service.ts b/apps/api/src/app/admin/admin.service.ts index 5e9b1a882..31b28a855 100644 --- a/apps/api/src/app/admin/admin.service.ts +++ b/apps/api/src/app/admin/admin.service.ts @@ -349,8 +349,8 @@ export class AdminService { if (value) { response = await this.propertyService.put({ - value, - key + key, + value }); } else { response = await this.propertyService.delete({ diff --git a/apps/api/src/app/admin/pipes/property-key.pipe.ts b/apps/api/src/app/admin/pipes/property-key.pipe.ts index fca4c9049..a980b552b 100644 --- a/apps/api/src/app/admin/pipes/property-key.pipe.ts +++ b/apps/api/src/app/admin/pipes/property-key.pipe.ts @@ -8,10 +8,14 @@ export class PropertyKeyPipe implements PipeTransform { private readonly allowedKeys: Set; public constructor() { - this.allowedKeys = new Set( + this.allowedKeys = new Set( Object.entries(config) - .filter(([key]) => key.startsWith('PROPERTY_')) - .map(([, value]) => value as string) + .filter(([key]) => { + return key.startsWith('PROPERTY_'); + }) + .map(([, value]) => { + return value as string; + }) ); }