From 32341d03e78b699793786a9921d1fcd573d189f9 Mon Sep 17 00:00:00 2001
From: KenTandrian <kenricktan11@gmail.com>
Date: Mon, 23 Mar 2026 21:51:30 +0700
Subject: [PATCH] resolve comments

---
 apps/client/src/app/app.component.ts         | 26 +++++++++-----------
 apps/client/src/app/interfaces/interfaces.ts |  8 ++++++
 2 files changed, 19 insertions(+), 15 deletions(-)
 create mode 100644 apps/client/src/app/interfaces/interfaces.ts

diff --git a/apps/client/src/app/app.component.ts b/apps/client/src/app/app.component.ts
index 6ebc01c1e..201c2f994 100644
--- a/apps/client/src/app/app.component.ts
+++ b/apps/client/src/app/app.component.ts
@@ -22,7 +22,6 @@ import { Title } from '@angular/platform-browser';
 import {
   ActivatedRoute,
   NavigationEnd,
-  Params,
   PRIMARY_OUTLET,
   Router,
   RouterLink,
@@ -37,15 +36,10 @@ import { filter } from 'rxjs/operators';
 import { GfFooterComponent } from './components/footer/footer.component';
 import { GfHeaderComponent } from './components/header/header.component';
 import { GfHoldingDetailDialogComponent } from './components/holding-detail-dialog/holding-detail-dialog.component';
+import { GfAppQueryParams } from './interfaces/interfaces';
 import { ImpersonationStorageService } from './services/impersonation-storage.service';
 import { UserService } from './services/user/user.service';
 
-export interface GfAppQueryParams extends Params {
-  dataSource?: DataSource;
-  holdingDetailDialog?: string;
-  symbol?: string;
-}
-
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
   imports: [GfFooterComponent, GfHeaderComponent, RouterLink, RouterOutlet],
@@ -91,15 +85,16 @@ export class GfAppComponent implements OnInit {
 
     this.route.queryParams
       .pipe(takeUntilDestroyed(this.destroyRef))
-      .subscribe((params: GfAppQueryParams) => {
-        const { dataSource, holdingDetailDialog, symbol } = params;
-        if (dataSource && holdingDetailDialog && symbol) {
-          this.openHoldingDetailDialog({
-            dataSource,
-            symbol
-          });
+      .subscribe(
+        ({ dataSource, holdingDetailDialog, symbol }: GfAppQueryParams) => {
+          if (dataSource && holdingDetailDialog && symbol) {
+            this.openHoldingDetailDialog({
+              dataSource,
+              symbol
+            });
+          }
         }
-      });
+      );
 
     addIcons({ openOutline });
   }
@@ -229,6 +224,7 @@ export class GfAppComponent implements OnInit {
 
   public onClickSystemMessage() {
     const systemMessage = this.user?.systemMessage;
+
     if (!systemMessage) {
       return;
     }
diff --git a/apps/client/src/app/interfaces/interfaces.ts b/apps/client/src/app/interfaces/interfaces.ts
new file mode 100644
index 000000000..493eff4ab
--- /dev/null
+++ b/apps/client/src/app/interfaces/interfaces.ts
@@ -0,0 +1,8 @@
+import type { Params } from '@angular/router';
+import type { DataSource } from '@prisma/client';
+
+export interface GfAppQueryParams extends Params {
+  dataSource?: DataSource;
+  holdingDetailDialog?: string;
+  symbol?: string;
+}