From 333c29fd88e3fc72be5d65a3166cbe7dae183395 Mon Sep 17 00:00:00 2001
From: francisco <francisco@innonova.ch>
Date: Tue, 25 Apr 2023 20:59:17 +0200
Subject: [PATCH] adress pr comments

---
 apps/api/src/app/portfolio/portfolio.service.ts | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts
index 64ed9efe3..8e368d667 100644
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@@ -462,16 +462,16 @@ export class PortfolioService {
     });
 
     const holdings: PortfolioDetails['holdings'] = {};
-    const totalInvestmentInBaseCurrency = currentPositions.currentValue.plus(
+    const totalValueInBaseCurrency = currentPositions.currentValue.plus(
       cashDetails.balanceInBaseCurrency
     );
 
-    const isFilteredByAccount = filters.some(
-      (filter) => filter.type === 'ACCOUNT'
-    );
+    const isFilteredByAccount = filters.some((filter) => {
+      return filter.type === 'ACCOUNT';
+    });
 
     let filteredValueInBaseCurrency = isFilteredByAccount
-      ? totalInvestmentInBaseCurrency
+      ? totalValueInBaseCurrency
       : currentPositions.currentValue;
 
     if (
@@ -571,9 +571,9 @@ export class PortfolioService {
       };
     }
 
-    const isFilteredByCash = filters.some(
-      (filter) => filter.type === 'ASSET_CLASS' && filter.id === 'CASH'
-    );
+    const isFilteredByCash = filters.some((filter) => {
+      return filter.type === 'ASSET_CLASS' && filter.id === 'CASH';
+    });
 
     if (filters.length === 0 || isFilteredByCash || isFilteredByAccount) {
       const cashPositions = await this.getCashPositions({