Browse Source
Bugfix/numeric parsing error in X-ray page (#6198)
* Fix numeric parsing error related to cash positions
* Update changelog
pull/6199/head^2
Thomas Kaul
3 days ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with
8 additions and
5 deletions
-
CHANGELOG.md
-
apps/api/src/app/portfolio/calculator/portfolio-calculator.ts
-
apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-cash.spec.ts
-
apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-valuable.spec.ts
|
|
|
@ -12,6 +12,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
- Removed the deprecated platforms from the info service |
|
|
|
- Removed the deprecated activities from the endpoint `GET api/v1/portfolio/holding/:dataSource/:symbol` |
|
|
|
|
|
|
|
### Fixed |
|
|
|
|
|
|
|
- Fixed a numeric parsing error related to cash positions on the _X-ray_ page |
|
|
|
|
|
|
|
## 2.230.0 - 2026-01-14 |
|
|
|
|
|
|
|
### Added |
|
|
|
|
|
|
|
@ -433,9 +433,8 @@ export abstract class PortfolioCalculator { |
|
|
|
investment: totalInvestment, |
|
|
|
investmentWithCurrencyEffect: totalInvestmentWithCurrencyEffect, |
|
|
|
marketPrice: |
|
|
|
marketSymbolMap[endDateString]?.[item.symbol]?.toNumber() ?? null, |
|
|
|
marketPriceInBaseCurrency: |
|
|
|
marketPriceInBaseCurrency?.toNumber() ?? null, |
|
|
|
marketSymbolMap[endDateString]?.[item.symbol]?.toNumber() ?? 1, |
|
|
|
marketPriceInBaseCurrency: marketPriceInBaseCurrency?.toNumber() ?? 1, |
|
|
|
netPerformance: !hasErrors ? (netPerformance ?? null) : null, |
|
|
|
netPerformancePercentage: !hasErrors |
|
|
|
? (netPerformancePercentage ?? null) |
|
|
|
|
|
|
|
@ -247,7 +247,7 @@ describe('PortfolioCalculator', () => { |
|
|
|
includeInTotalAssetValue: false, |
|
|
|
investment: new Big(1820), |
|
|
|
investmentWithCurrencyEffect: new Big(1750), |
|
|
|
marketPrice: null, |
|
|
|
marketPrice: 1, |
|
|
|
marketPriceInBaseCurrency: 0.91, |
|
|
|
netPerformance: new Big(0), |
|
|
|
netPerformancePercentage: new Big(0), |
|
|
|
|
|
|
|
@ -129,7 +129,7 @@ describe('PortfolioCalculator', () => { |
|
|
|
grossPerformanceWithCurrencyEffect: new Big('0'), |
|
|
|
investment: new Big('500000'), |
|
|
|
investmentWithCurrencyEffect: new Big('500000'), |
|
|
|
marketPrice: null, |
|
|
|
marketPrice: 1, |
|
|
|
marketPriceInBaseCurrency: 500000, |
|
|
|
netPerformance: new Big('0'), |
|
|
|
netPerformancePercentage: new Big('0'), |
|
|
|
|