From b3ec3530746fa89c5266f5ff84c9238936455957 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 7 Jun 2025 13:43:06 +0200 Subject: [PATCH 1/2] Feature/change interpolation syntax in i18n service (#4849) * Change interpolation syntax from {var} to ${var} --- apps/api/src/services/i18n/i18n.service.ts | 2 +- apps/client/src/app/pages/i18n/i18n-page.html | 8 ++++---- apps/client/src/locales/messages.ca.xlf | 8 ++++---- apps/client/src/locales/messages.de.xlf | 8 ++++---- apps/client/src/locales/messages.es.xlf | 8 ++++---- apps/client/src/locales/messages.fr.xlf | 8 ++++---- apps/client/src/locales/messages.it.xlf | 8 ++++---- apps/client/src/locales/messages.nl.xlf | 8 ++++---- apps/client/src/locales/messages.pl.xlf | 8 ++++---- apps/client/src/locales/messages.pt.xlf | 8 ++++---- apps/client/src/locales/messages.tr.xlf | 8 ++++---- apps/client/src/locales/messages.uk.xlf | 8 ++++---- apps/client/src/locales/messages.xlf | 4 ++-- apps/client/src/locales/messages.zh.xlf | 8 ++++---- 14 files changed, 51 insertions(+), 51 deletions(-) diff --git a/apps/api/src/services/i18n/i18n.service.ts b/apps/api/src/services/i18n/i18n.service.ts index e928775d1..533abf2e2 100644 --- a/apps/api/src/services/i18n/i18n.service.ts +++ b/apps/api/src/services/i18n/i18n.service.ts @@ -42,7 +42,7 @@ export class I18nService { if (placeholders) { for (const [key, value] of Object.entries(placeholders)) { - translatedText = translatedText.replace(`{${key}}`, String(value)); + translatedText = translatedText.replace(`\${${key}}`, String(value)); } } diff --git a/apps/client/src/app/pages/i18n/i18n-page.html b/apps/client/src/app/pages/i18n/i18n-page.html index f54a45b3f..565d5b68f 100644 --- a/apps/client/src/app/pages/i18n/i18n-page.html +++ b/apps/client/src/app/pages/i18n/i18n-page.html @@ -20,12 +20,12 @@
  • Fee Ratio
  • - The fees do exceed {thresholdMax}% of your initial investment - ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment + (${feeRatio}%)
  • - The fees do not exceed {thresholdMax}% of your initial - investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial + investment (${feeRatio}%)
  • Open Source Wealth Management Software
    • diff --git a/apps/client/src/locales/messages.ca.xlf b/apps/client/src/locales/messages.ca.xlf index b90757a68..bfab9a8a2 100644 --- a/apps/client/src/locales/messages.ca.xlf +++ b/apps/client/src/locales/messages.ca.xlf @@ -7649,16 +7649,16 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 26 diff --git a/apps/client/src/locales/messages.de.xlf b/apps/client/src/locales/messages.de.xlf index ba6802bfe..bd05b886c 100644 --- a/apps/client/src/locales/messages.de.xlf +++ b/apps/client/src/locales/messages.de.xlf @@ -7649,16 +7649,16 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) - Die Gebühren übersteigen {thresholdMax}% deiner ursprünglichen Investition ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + Die Gebühren übersteigen ${thresholdMax}% deiner ursprünglichen Investition (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) - Die Gebühren übersteigen {thresholdMax}% deiner ursprünglichen Investition ({feeRatio}%) nicht + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + Die Gebühren übersteigen ${thresholdMax}% deiner ursprünglichen Investition (${feeRatio}%) nicht apps/client/src/app/pages/i18n/i18n-page.html 26 diff --git a/apps/client/src/locales/messages.es.xlf b/apps/client/src/locales/messages.es.xlf index 08fd82259..76f53b029 100644 --- a/apps/client/src/locales/messages.es.xlf +++ b/apps/client/src/locales/messages.es.xlf @@ -7650,16 +7650,16 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 26 diff --git a/apps/client/src/locales/messages.fr.xlf b/apps/client/src/locales/messages.fr.xlf index e8eef67fd..fac798e8c 100644 --- a/apps/client/src/locales/messages.fr.xlf +++ b/apps/client/src/locales/messages.fr.xlf @@ -7649,16 +7649,16 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 26 diff --git a/apps/client/src/locales/messages.it.xlf b/apps/client/src/locales/messages.it.xlf index f542d5dca..5ef471fdf 100644 --- a/apps/client/src/locales/messages.it.xlf +++ b/apps/client/src/locales/messages.it.xlf @@ -7650,16 +7650,16 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 26 diff --git a/apps/client/src/locales/messages.nl.xlf b/apps/client/src/locales/messages.nl.xlf index fd1bfa6ac..3439f03c0 100644 --- a/apps/client/src/locales/messages.nl.xlf +++ b/apps/client/src/locales/messages.nl.xlf @@ -7649,16 +7649,16 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 26 diff --git a/apps/client/src/locales/messages.pl.xlf b/apps/client/src/locales/messages.pl.xlf index c9030efba..38f2a5725 100644 --- a/apps/client/src/locales/messages.pl.xlf +++ b/apps/client/src/locales/messages.pl.xlf @@ -7649,16 +7649,16 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 26 diff --git a/apps/client/src/locales/messages.pt.xlf b/apps/client/src/locales/messages.pt.xlf index 4284198ae..2635a020a 100644 --- a/apps/client/src/locales/messages.pt.xlf +++ b/apps/client/src/locales/messages.pt.xlf @@ -7649,16 +7649,16 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 26 diff --git a/apps/client/src/locales/messages.tr.xlf b/apps/client/src/locales/messages.tr.xlf index 9d96ee0cf..6eab8df6c 100644 --- a/apps/client/src/locales/messages.tr.xlf +++ b/apps/client/src/locales/messages.tr.xlf @@ -7649,16 +7649,16 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 26 diff --git a/apps/client/src/locales/messages.uk.xlf b/apps/client/src/locales/messages.uk.xlf index 3c4bc4a8b..24ef55c37 100644 --- a/apps/client/src/locales/messages.uk.xlf +++ b/apps/client/src/locales/messages.uk.xlf @@ -7649,16 +7649,16 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 26 diff --git a/apps/client/src/locales/messages.xlf b/apps/client/src/locales/messages.xlf index 2980807da..9a3af47b8 100644 --- a/apps/client/src/locales/messages.xlf +++ b/apps/client/src/locales/messages.xlf @@ -6884,14 +6884,14 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 26 diff --git a/apps/client/src/locales/messages.zh.xlf b/apps/client/src/locales/messages.zh.xlf index 21301ba16..4f9202df8 100644 --- a/apps/client/src/locales/messages.zh.xlf +++ b/apps/client/src/locales/messages.zh.xlf @@ -7650,16 +7650,16 @@ - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 22 - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) - The fees do not exceed {thresholdMax}% of your initial investment ({feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) + The fees do not exceed ${thresholdMax}% of your initial investment (${feeRatio}%) apps/client/src/app/pages/i18n/i18n-page.html 26 From 042112faa67380c81f74840f095f8f891c29e9d0 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 7 Jun 2025 13:43:33 +0200 Subject: [PATCH 2/2] Feature/improve language localization for de 20250607 (#4848) * Update translation * Update changelog --- CHANGELOG.md | 6 ++++++ apps/client/src/locales/messages.de.xlf | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 19763952b..be60a7bfe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## Unreleased + +### Changed + +- Improved the language localization for German (`de`) + ## 2.167.0 - 2025-06-07 ### Added diff --git a/apps/client/src/locales/messages.de.xlf b/apps/client/src/locales/messages.de.xlf index bd05b886c..b7b7d6663 100644 --- a/apps/client/src/locales/messages.de.xlf +++ b/apps/client/src/locales/messages.de.xlf @@ -7128,7 +7128,7 @@ rules align with your portfolio. - Regeln werden von Ihrem Portfolio erfüllt. + Regeln werden von deinem Portfolio erfüllt. apps/client/src/app/pages/portfolio/x-ray/x-ray-page.component.html 58