Browse Source
Bugfix/add fallback if exchange service is not initialized (#264)
* Add fallback and log error
* Update changelog
pull/279/head
Thomas
3 years ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with
16 additions and
1 deletions
-
CHANGELOG.md
-
apps/api/src/services/exchange-rate-data.service.ts
|
|
@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
|
|
|
|
## Unreleased |
|
|
|
|
|
|
|
### Fixed |
|
|
|
|
|
|
|
- Added a fallback if the exchange rate service has not been initialized correctly |
|
|
|
|
|
|
|
## Unreleased |
|
|
|
|
|
|
|
### Changed |
|
|
|
|
|
|
|
- Hid the pagination of tabs |
|
|
|
|
|
@ -2,6 +2,7 @@ import { DATE_FORMAT, getYesterday } from '@ghostfolio/common/helper'; |
|
|
|
import { Injectable } from '@nestjs/common'; |
|
|
|
import { Currency } from '@prisma/client'; |
|
|
|
import { format } from 'date-fns'; |
|
|
|
import { isNumber } from 'lodash'; |
|
|
|
|
|
|
|
import { DataProviderService } from './data-provider.service'; |
|
|
|
|
|
|
@ -83,7 +84,15 @@ export class ExchangeRateDataService { |
|
|
|
factor = this.currencies[`${aFromCurrency}${aToCurrency}`]; |
|
|
|
} |
|
|
|
|
|
|
|
return factor * aValue; |
|
|
|
if (isNumber(factor)) { |
|
|
|
return factor * aValue; |
|
|
|
} |
|
|
|
|
|
|
|
// Fallback with error, if currencies are not available
|
|
|
|
console.error( |
|
|
|
`No exchange rate has been found for ${aFromCurrency}${aToCurrency}` |
|
|
|
); |
|
|
|
return aValue; |
|
|
|
} |
|
|
|
|
|
|
|
private addPairs(aCurrency1: Currency, aCurrency2: Currency) { |
|
|
|