From 37728c14353a1e380aee2fbf6f699578b3ef5e54 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sven=20G=C3=BCnther?= Date: Sun, 28 Dec 2025 10:46:48 +0100 Subject: [PATCH] applied feedback - Icon Change from reader-outline to code-slash-outline for the Scraper Configuration tab - Form Persistence Fix - Removed the nested
tag in the Scraper Configuration tab that was causing the "Form submission canceled because the form is not connected" warning - The scraper configuration fields are now properly connected to the main assetProfileForm through the formGroupName directive --- CHANGELOG.md | 1 + .../asset-profile-dialog.component.ts | 9 ++++++++- .../asset-profile-dialog/asset-profile-dialog.html | 6 +++--- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 932220081..db7564cd2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed +- Extracted the scraper configuration to a dedicated tab in the asset profile dialog of the admin control panel - Lifted the asset profile identifier editing restriction for `MANUAL` data sources in the asset profile details dialog of the admin control panel - Upgraded `angular` from version `20.2.4` to `20.3.9` - Upgraded `Nx` from version `21.5.1` to `22.1.3` diff --git a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts index 62d8da869..31578382b 100644 --- a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts +++ b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts @@ -78,6 +78,7 @@ import { format } from 'date-fns'; import { StatusCodes } from 'http-status-codes'; import { addIcons } from 'ionicons'; import { + codeSlashOutline, createOutline, ellipsisVertical, readerOutline, @@ -252,7 +253,13 @@ export class GfAssetProfileDialogComponent implements OnDestroy, OnInit { private snackBar: MatSnackBar, private userService: UserService ) { - addIcons({ createOutline, ellipsisVertical, readerOutline, serverOutline }); + addIcons({ + codeSlashOutline, + createOutline, + ellipsisVertical, + readerOutline, + serverOutline + }); } public get canSaveAssetProfileIdentifier() { diff --git a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html index 79d0e20e1..a60e10edc 100644 --- a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html +++ b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html @@ -467,11 +467,11 @@ @if (assetProfile?.dataSource === 'MANUAL') { - +
Scraper Configuration
- +
- +
}