From 38c71fb7783186fea1c62b81a51493145c7b92cd Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sun, 12 Oct 2025 13:36:56 +0200 Subject: [PATCH] Refactoring --- apps/client/src/app/app.component.html | 4 +- apps/client/src/app/app.component.ts | 34 -- .../components/footer/footer.component.html | 310 +++++++++--------- .../components/footer/footer.component.scss | 2 +- .../footer/footer.component.spec.ts | 32 -- 5 files changed, 158 insertions(+), 224 deletions(-) delete mode 100644 apps/client/src/app/components/footer/footer.component.spec.ts diff --git a/apps/client/src/app/app.component.html b/apps/client/src/app/app.component.html index c562f6662..61d5023e2 100644 --- a/apps/client/src/app/app.component.html +++ b/apps/client/src/app/app.component.html @@ -47,5 +47,7 @@ @if (showFooter) { - + } diff --git a/apps/client/src/app/app.component.ts b/apps/client/src/app/app.component.ts index e33ba15b6..bddd7d3da 100644 --- a/apps/client/src/app/app.component.ts +++ b/apps/client/src/app/app.component.ts @@ -55,32 +55,13 @@ export class AppComponent implements OnDestroy, OnInit { public deviceType: string; public hasImpersonationId: boolean; public hasInfoMessage: boolean; - public hasPermissionForStatistics: boolean; - public hasPermissionForSubscription: boolean; - public hasPermissionToAccessFearAndGreedIndex: boolean; public hasPermissionToChangeDateRange: boolean; public hasPermissionToChangeFilters: boolean; public hasPromotion = false; public hasTabs = false; public info: InfoItem; public pageTitle: string; - public routerLinkAbout = publicRoutes.about.routerLink; - public routerLinkAboutChangelog = - publicRoutes.about.subRoutes.changelog.routerLink; - public routerLinkAboutLicense = - publicRoutes.about.subRoutes.license.routerLink; - public routerLinkAboutPrivacyPolicy = - publicRoutes.about.subRoutes.privacyPolicy.routerLink; - public routerLinkAboutTermsOfService = - publicRoutes.about.subRoutes.termsOfService.routerLink; - public routerLinkBlog = publicRoutes.blog.routerLink; - public routerLinkFaq = publicRoutes.faq.routerLink; - public routerLinkFeatures = publicRoutes.features.routerLink; - public routerLinkMarkets = publicRoutes.markets.routerLink; - public routerLinkOpenStartup = publicRoutes.openStartup.routerLink; - public routerLinkPricing = publicRoutes.pricing.routerLink; public routerLinkRegister = publicRoutes.register.routerLink; - public routerLinkResources = publicRoutes.resources.routerLink; public showFooter = false; public user: User; @@ -125,21 +106,6 @@ export class AppComponent implements OnDestroy, OnInit { this.deviceType = this.deviceService.getDeviceInfo().deviceType; this.info = this.dataService.fetchInfo(); - this.hasPermissionForSubscription = hasPermission( - this.info?.globalPermissions, - permissions.enableSubscription - ); - - this.hasPermissionForStatistics = hasPermission( - this.info?.globalPermissions, - permissions.enableStatistics - ); - - this.hasPermissionToAccessFearAndGreedIndex = hasPermission( - this.info?.globalPermissions, - permissions.enableFearAndGreedIndex - ); - this.hasPromotion = !!this.info?.subscriptionOffer?.coupon || !!this.info?.subscriptionOffer?.durationExtension; diff --git a/apps/client/src/app/components/footer/footer.component.html b/apps/client/src/app/components/footer/footer.component.html index 350a81d32..155f27f68 100644 --- a/apps/client/src/app/components/footer/footer.component.html +++ b/apps/client/src/app/components/footer/footer.component.html @@ -1,183 +1,181 @@ - + +
+
+
Ghostfolio
+
+
diff --git a/apps/client/src/app/components/footer/footer.component.scss b/apps/client/src/app/components/footer/footer.component.scss index 7ab188f4c..3bff80ccd 100644 --- a/apps/client/src/app/components/footer/footer.component.scss +++ b/apps/client/src/app/components/footer/footer.component.scss @@ -1,6 +1,6 @@ :host { - display: block; background-color: rgba(var(--palette-foreground-text), 0.05); + display: block; font-size: 90%; .logotype { diff --git a/apps/client/src/app/components/footer/footer.component.spec.ts b/apps/client/src/app/components/footer/footer.component.spec.ts deleted file mode 100644 index 17f675ccd..000000000 --- a/apps/client/src/app/components/footer/footer.component.spec.ts +++ /dev/null @@ -1,32 +0,0 @@ -import { GfFooterComponent } from './footer.component'; - -// TODO: Fix Jest configuration for Ionic components -describe.skip('GfFooterComponent', () => { - let component: GfFooterComponent; - - beforeEach(() => { - component = new GfFooterComponent(); - }); - - it('should create', () => { - expect(component).toBeTruthy(); - }); - - it('should have current year property', () => { - expect(component.currentYear).toBe(new Date().getFullYear()); - }); - - it('should have router links defined', () => { - expect(component.routerLinkAbout).toBeDefined(); - expect(component.routerLinkFeatures).toBeDefined(); - expect(component.routerLinkResources).toBeDefined(); - }); - - it('should initialize permission properties', () => { - component.ngOnChanges(); - - expect(component.hasPermissionForStatistics).toBeDefined(); - expect(component.hasPermissionForSubscription).toBeDefined(); - expect(component.hasPermissionToAccessFearAndGreedIndex).toBeDefined(); - }); -});