Browse Source

Code review changes

pull/4390/head
csehatt741 6 months ago
committed by Thomas Kaul
parent
commit
3b360af148
  1. 11
      apps/api/src/app/account/account.service.ts
  2. 14
      apps/api/src/app/export/export.service.ts

11
apps/api/src/app/account/account.service.ts

@ -69,7 +69,12 @@ export class AccountService {
> { > {
const { include = {}, skip, take, cursor, where, orderBy } = params; const { include = {}, skip, take, cursor, where, orderBy } = params;
include.balances = { orderBy: { date: 'desc' } }; const isBalancesIncluded = !!include.balances;
include.balances = {
orderBy: { date: 'desc' },
...(isBalancesIncluded ? {} : { take: 1 })
};
const accounts = await this.prismaService.account.findMany({ const accounts = await this.prismaService.account.findMany({
cursor, cursor,
@ -83,6 +88,10 @@ export class AccountService {
return accounts.map((account) => { return accounts.map((account) => {
account = { ...account, balance: account.balances[0]?.value ?? 0 }; account = { ...account, balance: account.balances[0]?.value ?? 0 };
if (!isBalancesIncluded) {
delete account.balances;
}
return account; return account;
}); });
} }

14
apps/api/src/app/export/export.service.ts

@ -31,6 +31,7 @@ export class ExportService {
const accounts = ( const accounts = (
await this.accountService.accounts({ await this.accountService.accounts({
include: { include: {
balances: true,
Platform: true Platform: true
}, },
orderBy: { orderBy: {
@ -56,7 +57,9 @@ export class ExportService {
return { return {
balance, balance,
balances, balances: balances.map(({ date, value }) => {
return { date: date.toISOString(), value };
}),
comment, comment,
currency, currency,
id, id,
@ -96,14 +99,7 @@ export class ExportService {
return { return {
meta: { date: new Date().toISOString(), version: environment.version }, meta: { date: new Date().toISOString(), version: environment.version },
accounts: accounts.map(({ balances, ...account }) => { accounts,
return {
balances: balances.map(({ date, value }) => {
return { date: date.toISOString(), value };
}),
...account
};
}),
platforms: Object.values(platformsMap), platforms: Object.values(platformsMap),
tags, tags,
activities: activities.map( activities: activities.map(

Loading…
Cancel
Save