Browse Source

Revert markets from controller

pull/3869/head
Thomas Kaul 11 months ago
parent
commit
407c7e06a2
  1. 3
      apps/api/src/app/endpoints/public/public.controller.ts
  2. 5
      apps/api/src/app/portfolio/portfolio.controller.ts
  3. 8
      libs/common/src/lib/interfaces/responses/public-portfolio-response.interface.ts

3
apps/api/src/app/endpoints/public/public.controller.ts

@ -57,7 +57,7 @@ export class PublicController {
} }
const [ const [
{ holdings, markets }, { holdings },
{ performance: performance1d }, { performance: performance1d },
{ performance: performanceMax }, { performance: performanceMax },
{ performance: performanceYtd } { performance: performanceYtd }
@ -80,7 +80,6 @@ export class PublicController {
hasDetails, hasDetails,
alias: access.alias, alias: access.alias,
holdings: {}, holdings: {},
markets: hasDetails ? markets : undefined,
performance: { performance: {
'1d': { '1d': {
relativeChange: relativeChange:

5
apps/api/src/app/portfolio/portfolio.controller.ts

@ -95,7 +95,7 @@ export class PortfolioController {
filterByTags filterByTags
}); });
const { accounts, hasErrors, holdings, markets, platforms, summary } = const { accounts, hasErrors, holdings, platforms, summary } =
await this.portfolioService.getDetails({ await this.portfolioService.getDetails({
dateRange, dateRange,
filters, filters,
@ -214,8 +214,7 @@ export class PortfolioController {
hasError, hasError,
holdings, holdings,
platforms, platforms,
summary: portfolioSummary, summary: portfolioSummary
markets: hasDetails ? markets : undefined
}; };
} }

8
libs/common/src/lib/interfaces/responses/public-portfolio-response.interface.ts

@ -1,5 +1,3 @@
import { Market } from '@ghostfolio/common/types';
import { PortfolioPosition } from '../portfolio-position.interface'; import { PortfolioPosition } from '../portfolio-position.interface';
export interface PublicPortfolioResponse extends PublicPortfolioResponseV1 { export interface PublicPortfolioResponse extends PublicPortfolioResponseV1 {
@ -24,12 +22,6 @@ export interface PublicPortfolioResponse extends PublicPortfolioResponseV1 {
| 'valueInPercentage' | 'valueInPercentage'
>; >;
}; };
markets?: {
[key in Market]: {
name: string;
value: number;
};
};
} }
interface PublicPortfolioResponseV1 { interface PublicPortfolioResponseV1 {

Loading…
Cancel
Save