diff --git a/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts b/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts index 764d4b058..51dcee24c 100644 --- a/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts +++ b/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts @@ -309,7 +309,6 @@ export class AnalysisPageComponent implements OnDestroy, OnInit { } private update() { - this.isLoadingBenchmarkComparator = true; this.isLoadingInvestmentChart = true; this.dataService @@ -386,34 +385,36 @@ export class AnalysisPageComponent implements OnDestroy, OnInit { private updateBenchmarkDataItems() { this.benchmarkDataItems = []; - this.isLoadingBenchmarkComparator = false; - - if (!this.user.settings.benchmark) return; - - const { dataSource, symbol } = - this.benchmarks.find(({ id }) => { - return id === this.user.settings.benchmark; - }) ?? {}; - - if (dataSource && symbol) { - this.isLoadingBenchmarkComparator = true; - this.dataService - .fetchBenchmarkBySymbol({ - dataSource, - symbol, - startDate: this.firstOrderDate - }) - .pipe(takeUntil(this.unsubscribeSubject)) - .subscribe(({ marketData }) => { - this.benchmarkDataItems = marketData.map(({ date, value }) => { - return { - date, - value - }; - }); - this.isLoadingBenchmarkComparator = false; - }); + if (this.user.settings.benchmark) { + const { dataSource, symbol } = + this.benchmarks.find(({ id }) => { + return id === this.user.settings.benchmark; + }) ?? {}; + + if (dataSource && symbol) { + this.isLoadingBenchmarkComparator = true; + + this.dataService + .fetchBenchmarkBySymbol({ + dataSource, + symbol, + startDate: this.firstOrderDate + }) + .pipe(takeUntil(this.unsubscribeSubject)) + .subscribe(({ marketData }) => { + this.benchmarkDataItems = marketData.map(({ date, value }) => { + return { + date, + value + }; + }); + + this.isLoadingBenchmarkComparator = false; + + this.changeDetectorRef.markForCheck(); + }); + } } } } diff --git a/apps/client/src/app/pages/portfolio/analysis/analysis-page.html b/apps/client/src/app/pages/portfolio/analysis/analysis-page.html index 3ae58595e..f7af5d476 100644 --- a/apps/client/src/app/pages/portfolio/analysis/analysis-page.html +++ b/apps/client/src/app/pages/portfolio/analysis/analysis-page.html @@ -3,7 +3,7 @@
@@ -23,7 +23,7 @@ [benchmarks]="benchmarks" [colorScheme]="user?.settings?.colorScheme" [daysInMarket]="daysInMarket" - [isLoading]="isLoadingBenchmarkComparator" + [isLoading]="isLoadingBenchmarkComparator || isLoadingInvestmentChart" [locale]="user?.settings?.locale" [performanceDataItems]="performanceDataItemsInPercentage" [user]="user" @@ -149,7 +149,7 @@ [daysInMarket]="daysInMarket" [historicalDataItems]="performanceDataItems" [isInPercent]="hasImpersonationId || user.settings.isRestrictedView" - [isLoading]="isLoadingBenchmarkComparator" + [isLoading]="isLoadingInvestmentChart" [locale]="user?.settings?.locale" [range]="user?.settings?.dateRange" >