From 45632bc9de5290cfa432c2b4841f4d0d096a771a Mon Sep 17 00:00:00 2001 From: Thomas <4159106+dtslvr@users.noreply.github.com> Date: Sat, 2 Oct 2021 10:13:39 +0200 Subject: [PATCH] Improve symbol conversion --- .../yahoo-finance/yahoo-finance.service.ts | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts index a4408abdb..25624c6a3 100644 --- a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts +++ b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts @@ -256,18 +256,19 @@ export const convertFromYahooFinanceSymbol = (aYahooFinanceSymbol: string) => { /** * Converts a symbol to a Yahoo Finance symbol * - * Currency: USDCHF=X - * Cryptocurrency: BTC-USD + * Currency: USDCHF -> USDCHF=X + * Cryptocurrency: BTCUSD -> BTC-USD + * DOGEUSD -> DOGE-USD + * SOL1USD -> SOL1-USD */ export const convertToYahooFinanceSymbol = (aSymbol: string) => { if (isCurrency(aSymbol)) { - if (isCrypto(aSymbol)) { + if (isCrypto(aSymbol) || isCrypto(aSymbol.replace('1', ''))) { // Add a dash before the last three characters // BTCUSD -> BTC-USD // DOGEUSD -> DOGE-USD - return `${aSymbol.substring(0, aSymbol.length - 3)}-${aSymbol.substring( - aSymbol.length - 3 - )}`; + // SOL1USD -> SOL1-USD + return aSymbol.replace('USD', '-USD'); } return `${aSymbol}=X`;