From 45f4eab7859d81fc8ba95ef8a8c6ba86e16273c1 Mon Sep 17 00:00:00 2001 From: dw-0 Date: Tue, 1 Oct 2024 20:53:06 +0200 Subject: [PATCH] fix: requested changes Signed-off-by: Dominik Willner --- apps/client/src/locales/messages.de.xlf | 2 +- .../lib/symbol-autocomplete/symbol-autocomplete.component.html | 2 +- .../lib/symbol-autocomplete/symbol-autocomplete.component.ts | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/client/src/locales/messages.de.xlf b/apps/client/src/locales/messages.de.xlf index aff0d63a6..dabb2bb66 100644 --- a/apps/client/src/locales/messages.de.xlf +++ b/apps/client/src/locales/messages.de.xlf @@ -7260,7 +7260,7 @@ Oops! Could not find any assets. - Hoppla! Es konnten keine Assets gefunden werden. + Ups! Es konnten leider keine Assets gefunden werden. libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.html 16 diff --git a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.html b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.html index 505309151..31ceb5dad 100644 --- a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.html +++ b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.html @@ -12,7 +12,7 @@ (optionSelected)="onUpdateSymbol($event)" > @if (!isLoading) { - @if (!empty && !filteredLookupItems.length) { + @if (hasNoItemsPostLoading) { Oops! Could not find any assets. diff --git a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts index 8e07ed674..d7e74157d 100644 --- a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts +++ b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts @@ -85,6 +85,7 @@ export class GfSymbolAutocompleteComponent @ViewChild('symbolAutocomplete') public symbolAutocomplete: MatAutocomplete; public control = new FormControl(); + public hasNoItemsPostLoading = false; public filteredLookupItems: (LookupItem & { assetSubClassString: string })[] = []; @@ -144,6 +145,7 @@ export class GfSymbolAutocompleteComponent }); this.isLoading = false; + this.hasNoItemsPostLoading = !this.filteredLookupItems.length; this.changeDetectorRef.markForCheck(); });